public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Charles Manning <cdhmanning@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v4] socfpga: Add socfpga preloader signing to mkimage
Date: Fri, 28 Feb 2014 10:46:23 +1300	[thread overview]
Message-ID: <201402281046.23216.manningc2@actrix.gen.nz> (raw)
In-Reply-To: <20140227211914.2382B381357@gemini.denx.de>


> > I can certainly avoid the ifdef, but there is already another one three
> > lines down
> > for the SAMSUNG case:
> >
> >  ifdef CONFIG_SOCFPGA
> > ALL-y += $(OBJTREE)/socfpga-signed-preloader.bin
> > endif
> >
> > ifdef CONFIG_SAMSUNG
> > ALL-y    += $(obj)/$(BOARD)-spl.bin
> > endif
> >
> > It seems odd to me that you would want different conventions in the same
> > Makefile,
> > but if that is what you want then that is what you will get.
>
> Existing poor code should not be used as reference for adding new bad
> code.  If possible, it should be imprived -patches are welcome.  In any
> case, please avoid the issues in new code.

Thank you for that, though it is not obvious which is poor code and which is 
good code and sometimes one must follow what exists for guidance.

I have cleared this up in the latest version that I posted.

-- Charles

  reply	other threads:[~2014-02-27 21:46 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-23 22:35 [U-Boot] [PATCH v4] socfpga: Add socfpga preloader signing to mkimage Charles Manning
2014-02-24  6:48 ` Wolfgang Denk
2014-02-24 19:18   ` Charles Manning
2014-02-24 21:03     ` Charles Manning
2014-02-27 21:19       ` Wolfgang Denk
2014-02-27 21:46         ` Charles Manning [this message]
2014-02-27 21:23       ` Wolfgang Denk
2014-02-27 21:52         ` Charles Manning
2014-02-26  1:17 ` [U-Boot] [PATCH v5] " Charles Manning
2014-02-26  6:16   ` Michal Simek
2014-02-26  7:42     ` Charles Manning
2014-02-26 20:00       ` Dinh Nguyen
2014-02-27  3:49   ` [U-Boot] [PATCH v6] " Charles Manning
2014-02-27 21:57     ` Wolfgang Denk
2014-02-27 22:43       ` Charles Manning
2014-03-05  4:36         ` Charles Manning
2014-02-27 22:34     ` Chin Liang See
2014-03-06  2:40     ` [U-Boot] [PATCH v7] " Charles Manning
2014-03-08 16:51       ` Gerhard Sittig
2014-03-10  3:04         ` Charles Manning
2014-03-10 19:36           ` Gerhard Sittig
2014-03-10 20:50             ` Charles Manning
2014-03-11  9:13             ` Masahiro Yamada
2014-03-11 19:49               ` Charles Manning

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201402281046.23216.manningc2@actrix.gen.nz \
    --to=cdhmanning@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox