From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Fri, 28 Feb 2014 11:54:39 +0100 Subject: [U-Boot] [PATCH] net: asix: don't pad odd-length TX packets In-Reply-To: References: <1393532822-28217-1-git-send-email-swarren@wwwdotorg.org> Message-ID: <201402281154.39505.marex@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Thursday, February 27, 2014 at 09:38:48 PM, Simon Glass wrote: > Hi Stephen, > > On 27 February 2014 13:27, Stephen Warren wrote: > > From: Stephen Warren > > > > For Ethernet/USB RX packets, the ASIX HW pads odd-sized packets so that > > they have an even size. Currently, asix_recv() does remove this padding, > > and asic_send() adds equivalent padding in the TX path. However, the HW > > does not appear to need this packing for TX packets in practical testing > > with "ASIX Elec. Corp. AX88x72A 000001" Vendor: 0x0b95 Product 0x7720 > > Version 0.1. The Linux kernel does no such padding for the TX path. > > > > Remove the padding from the TX path: > > > > * For consistency with the Linux kernel. > > * NVIDIA has a Tegra simulator which validates that the length of USB > > > > packets sent to an ASIX device matches the packet length value inside > > the packet data. Having U-Boot and the kernel do the same thing when > > creating the TX packets simplifies the simulator's validation. > > > > Cc: Lucas Stach > > Cc: Marek Vasut > > Cc: Simon Glass > > Signed-off-by: Stephen Warren > > My notes indicate I added this due to a problem I had at the time with > bootp. However, since you have tested it, perhaps the root cause was > somewhere else. > > Acked-by: Simon Glass Tested on two different ASIX dongles: 0x2001:0x3c05 ; DUB-E100 ; D-Link Corporation 0x0b95:0x7720 ; ZoWii ; Zoltan Tech Acked-by: Marek Vasut Tested-by: Marek Vasut Best regards, Marek Vasut