From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [U-Boot, V3] cfb_console: align fields in gzipped .bmp files
Date: Mon, 10 Mar 2014 17:28:13 -0400 [thread overview]
Message-ID: <20140310212813.GH16805@bill-the-cat> (raw)
In-Reply-To: <1394290552-3702-1-git-send-email-eric.nelson@boundarydevices.com>
On Sat, Mar 08, 2014 at 07:55:52AM -0700, Eric Nelson wrote:
> .bmp files contain 32-bit integers aligned at offsets of +2, +6,
> et cetera within the bmp_header structure (see include/bmp_layout.h).
>
> Support for gzip-compressed .bmp files is present in the cfb_console
> display subsystem by uncompressing them prior to use.
>
> This patch forces the in-memory header to be aligned properly
> for these compressed images by extracting them to a 2-byte
> offset in the memory returned by malloc. Since malloc will always
> return a 4-byte aligned value, this forces the .bmp header
> fields to be naturally aligned on 4-byte addresses.
>
> Refer to these files for more details:
> doc/README.displaying-bmps
> doc/README.arm-unaligned-accesses
>
> Signed-off-by: Eric Nelson <eric.nelson@boundarydevices.com>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140310/b041d9e0/attachment.pgp>
prev parent reply other threads:[~2014-03-10 21:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-22 21:04 [U-Boot] [PATCH] cfb_console: force natural alignment of unzipped bitmap images Eric Nelson
2014-02-22 22:49 ` Wolfgang Denk
2014-03-08 14:55 ` [U-Boot] [PATCH V3] cfb_console: align fields in gzipped .bmp files Eric Nelson
2014-03-10 21:28 ` Tom Rini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140310212813.GH16805@bill-the-cat \
--to=trini@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox