From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marex@denx.de>
Date: Wed, 12 Mar 2014 11:48:37 +0100
Subject: [U-Boot] [PATCH] arm: exynos: Squash bogus warnings in pinmux
In-Reply-To: <20140312085156.006cf034@amdc2363>
References: <1394478271-9837-1-git-send-email-marex@denx.de>
	<CAPnjgZ068jyZ+oeKvf15BpKnOmmMLvrB7V2NB0AW3vP5VVniWw@mail.gmail.com>
	<20140312085156.006cf034@amdc2363>
Message-ID: <201403121148.37761.marex@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Wednesday, March 12, 2014 at 08:51:56 AM, Lukasz Majewski wrote:
> Hi Simon, Marek,
> 
> > Hi Marek,
> > 
> > On 10 March 2014 13:04, Marek Vasut <marex@denx.de> wrote:
> > > Squash these warnings in pinmux.c found with GCC 4.8:
> > > 
> > > /arch/arm/cpu/armv7/exynos/pinmux.c: In function
> > > 'exynos_pinmux_config': /arch/arm/cpu/armv7/exynos/pinmux.c:687:28:
> > > warning: 'count' may be used uninitialized in this function
> > > [-Wmaybe-uninitialized] for (i = start; i < start + count; i++) { ^
> > > /arch/arm/cpu/armv7/exynos/pinmux.c:663:16: note: 'count' was
> > > declared here int i, start, count;
> > > 
> > >                 ^
> > > 
> > > /arch/arm/cpu/armv7/exynos/pinmux.c:687:28: warning: 'start' may be
> > > used uninitialized in this function [-Wmaybe-uninitialized] for (i
> > > = start; i < start + count; i++) { ^
> > > /arch/arm/cpu/armv7/exynos/pinmux.c:663:9: note: 'start' was
> > > declared here int i, start, count;
> > > 
> > >          ^
> > > 
> > > /arch/arm/cpu/armv7/exynos/pinmux.c:689:19: warning: 'bank' may be
> > > used uninitialized in this function [-Wmaybe-uninitialized]
> > > s5p_gpio_cfg_pin(bank, i, GPIO_FUNC(0x2)); ^
> > > /arch/arm/cpu/armv7/exynos/pinmux.c:662:24: note: 'bank' was
> > > declared here struct s5p_gpio_bank *bank;
> > > 
> > >                         ^
> > > 
> > > /arch/arm/cpu/armv7/exynos/pinmux.c: In function
> > > 'exynos_pinmux_config': /arch/arm/cpu/armv7/exynos/pinmux.c:687:28:
> > > warning: 'count' may be used uninitialized in this function
> > > [-Wmaybe-uninitialized] for (i = start; i < start + count; i++) { ^
> > > /arch/arm/cpu/armv7/exynos/pinmux.c:663:16: note: 'count' was
> > > declared here int i, start, count;
> > > 
> > >                 ^
> > > 
> > > /arch/arm/cpu/armv7/exynos/pinmux.c:687:28: warning: 'start' may be
> > > used uninitialized in this function [-Wmaybe-uninitialized] for (i
> > > = start; i < start + count; i++) { ^
> > > /arch/arm/cpu/armv7/exynos/pinmux.c:663:9: note: 'start' was
> > > declared here int i, start, count;
> > > 
> > >          ^
> > > 
> > > /arch/arm/cpu/armv7/exynos/pinmux.c:689:19: warning: 'bank' may be
> > > used uninitialized in this function [-Wmaybe-uninitialized]
> > > s5p_gpio_cfg_pin(bank, i, GPIO_FUNC(0x2)); ^
> > > /arch/arm/cpu/armv7/exynos/pinmux.c:662:24: note: 'bank' was
> > > declared here struct s5p_gpio_bank *bank;
> > > 
> > >                         ^
> > > 
> > > Note that the warning is bogus, the function can never be called
> > > with invalid 'peripheral' argument. GCC just cannot analyze this.
> > > 
> > > Signed-off-by: Marek Vasut <marex@denx.de>
> > > Cc: Naveen Krishna Chatradhi <ch.naveen@samsung.com>
> > > Cc: Akshay Saraswat <akshay.s@samsung.com>
> > > Cc: Rajeshwari S Shinde <rajeshwari.s@samsung.com>
> > > Cc: Simon Glass <sjg@chromium.org>
> > > Cc: Minkyu Kang <mk7.kang@samsung.com>
> > > Cc: Tom Rini <trini@ti.com>
> > 
> > Acked-by: Simon Glass <sjg@chromium.org>
> > 
> > Thanks Marek, great to get that annoyance fixed.
> 
> Fix for this issue has been already posted :-) (one week ago)
> 
> http://patchwork.ozlabs.org/patch/327065/
> 
> But I don't mind if Marek's patch will be applied directly by Tom
> before v2014.04 is released :-)

Aren't you missing the exynos5_mmc_config() in your patch ? Otherwise, I don't 
mind either way and I'd prefer if your patch (which came in earlier) was applied 
of course (unless you are missing the _mmc_config).