public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Masahiro Yamada <yamada.m@jp.panasonic.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] denali: review feedback
Date: Wed, 12 Mar 2014 18:53:16 +0900	[thread overview]
Message-ID: <20140312185316.6F51.AA925319@jp.panasonic.com> (raw)
In-Reply-To: <E1WNfgn-0002Yy-Q9@janus>

Hello Albert,


> 
> On Fri,  7 Mar 2014 21:52:54 +0900, Masahiro Yamada
> <yamada.m@jp.panasonic.com> wrote:
> 
> > For Chin Liang See
> > 
> > Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
> > ---
> 
> The patch subject / commit summary definitely needs to be more
> descriptive of the why and what of the patch content.
> 
> Amicalement,
> -- 
> Albert.

This is not meant to be applied.
I just sent a code diff to Chin because I wanted to suggest
how his patch file should be fixed in the next version.

I wish there had been a good way to prevent Patchwok
from picking up emails which include code diffs.


Best Regards
Masahiro Yamada

      reply	other threads:[~2014-03-12  9:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-07 12:52 [U-Boot] [PATCH] denali: review feedback Masahiro Yamada
2014-03-12  9:43 ` Albert ARIBAUD
2014-03-12  9:53   ` Masahiro Yamada [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140312185316.6F51.AA925319@jp.panasonic.com \
    --to=yamada.m@jp.panasonic.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox