From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Fri, 14 Mar 2014 10:17:07 -0400 Subject: [U-Boot] [PATCH v1 3/9] sunxi: initial sun7i dram setup support In-Reply-To: <1394793231-11922-3-git-send-email-ijc@hellion.org.uk> References: <1394793212.13270.89.camel@hastur.hellion.org.uk> <1394793231-11922-3-git-send-email-ijc@hellion.org.uk> Message-ID: <20140314141707.GG16360@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Fri, Mar 14, 2014 at 10:33:45AM +0000, Ian Campbell wrote: [snip] > +static void mctl_ddr3_reset(void) > +{ > + struct sunxi_dram_reg *dram = > + (struct sunxi_dram_reg *)SUNXI_DRAMC_BASE; > + > + { > + clrbits_le32(&dram->mcr, DRAM_MCR_RESET); > + udelay(2); > + setbits_le32(&dram->mcr, DRAM_MCR_RESET); > + } That seems like an odd construction, why the extra braces? And as for the rest of the code, lots of magic numbers to #define what/why (why udelay(2) and 22?) -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: