[U-Boot] [PATCH 08/10] exynos: dts: Enable LCD for snow

Simon Glass
2014-03-30T00:24:17Z

Hi Lukasz,

On 27 March 2014 11:23, Lukasz Majewski <l.majewski@samsung.com> wrote:

> Hi Simon,
>
> > Enable LCD for snow. This is a 1366 x 768 panel.
> >
> > Signed-off-by: Simon Glass <sjg@chromium.org>
> > ---
> >
> > arch/arm/dts/exynos5250-snow.dts | 44
> > ++++++++++++++++++++++++++++++++++++++++ 1 file changed, 44
> > insertions(+)
> >
> > diff --git a/arch/arm/dts/exynos5250-snow.dts
> > b/arch/arm/dts/exynos5250-snow.dts index 42a687b..725a1bf 100644
> > --- a/arch/arm/dts/exynos5250-snow.dts
> > +++ b/arch/arm/dts/exynos5250-snow.dts
> > @@ -192,4 +192,48 @@
> > /* UP LEFT */
> > 0x070b0067 0x070c0069>;
> > };
> > +
> > + fimd at 14400000 {
> > + samsung,vl-freq = <60>;
> > + samsung,vl-col = <1366>;
> > + samsung,vl-row = <768>;
> > + samsung,vl-width = <1366>;
> > + samsung,vl-height = <768>;
> > +
> > + samsung,vl-clkp;
> > + samsung,vl-dp;
> > + samsung,vl-hsp;
> > + samsung,vl-vsp;
> > +
> > + samsung,vl-bpix = <4>;
> > +
> > + samsung,vl-hspw = <32>;
> > + samsung,vl-hbpd = <80>;
> > + samsung,vl-hfpd = <48>;
> > + samsung,vl-vspw = <5>;
> > + samsung,vl-vbpd = <14>;
> > + samsung,vl-vfpd = <3>;
> > + samsung,vl-cmd-allow-len = <0xf>;
> > +
> > + samsung,winid = <0>;
> > + samsung,interface-mode = <1>;
> > + samsung,dp-enabled = <1>;
> > + samsung,dual-lcd-enabled = <0>;
> > + };
> > +
>
> I can only now regret that we have not stick to the Linux kernel DTS
> format and be ABI compatible with Linux (and add u-boot specific
> bindings as an extension).
>
> Now unfortunately it is too late.
>

I don't think it is too late. But until the GPIO numbering patch lands it's
really tricky to put GPIOs into the device tree on exynos. I think it would
be fairly easy to adjust this later.

Regards,
Simon