[U-Boot] [PATCH v2 5/9] sunxi: generic sun7i build infrastructure.

Hans de Goede
2014-03-22T20:07:23Z

Hi,

On 03/22/2014 08:31 PM, Wolfgang Denk wrote:
> Dear Hans de Goede,
>
> In message <532DA872.5000606@redhat.com> you wrote:
>>
>> No as said before the parts for which we don't have a Signed-off-by
>> for falls under b), since we took it from existing code which has clear
>> GPLv2+ license headers on each and every file.
>
> Can the code be properly attributed, i. e. does it have proper
> Signed-off-by: lines?
>
>>> using your real name (sorry, no pseudonyms or anonymous contributions.)
>>
>> Right but these are not Signed-off-by lines. Just as I may thank a tester
>> in a commit message with just his name because he does not want me to disclose
>> his email address, we are attributing people here with just there names.
>
> If these people attributed to the code, we should have their commits
> with their respective Signed-off-by: lines.

No, just no. How hard is it to read ? section b) clearly states:

"The contribution is based upon previous work that, to the best of my knowledge,
is covered under an appropriate open source license and I have the right under that
license to submit that work with modifications ..."

Nothing more nothing less, you're reading a whole lot stuff in between the
lines which is not there. Esp. notice the "to the best of my knowledge".

I don't remember the exact details, as I was not really active in the sunci community
at the time, but after some discussion we got the u-boot code from Allwinner themselves,
under the GPL, with GPL headers in place. See ie the first commit in the
sunxi repo:
https://github.com/linux-sunxi/u-boot-sunxi/commit/a38e8203867075a3cabc2d690855366852f87635

Which even has Tom Cubie <tangliang@allwinnertech.com> set as author, but does not
have his Signed-off-by, but does has "Henrik Nordstrom <henrik@henriknordstrom.net>"
Signed-off-by, which is 100% ok under section b).

Regards,

Hans

p.s.

This will be my last mail in the thread wrt the whole Signed-off-by discussion, your needless
strict reading of the s-o-b guidelines is causing way too much negative energy for me. I hope
you and Ian can work out a solution for this.