public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/1] imx-common: cpu: add fdt_file environment variable
Date: Sun, 30 Mar 2014 16:52:36 +0200	[thread overview]
Message-ID: <201403301652.36385.marex@denx.de> (raw)
In-Reply-To: <CAP9ODKrO3KX+UR1di9A3VdVuveVBi+ZqYgiwegATCQ7OaBhBRQ@mail.gmail.com>

On Sunday, March 30, 2014 at 12:04:31 AM, Otavio Salvador wrote:
> On Sat, Mar 29, 2014 at 7:34 PM, Troy Kisky
> 
> <troy.kisky@boundarydevices.com> wrote:
> > This removes one block in the move toward 1 u-boot
> > for both a mx6q (quad) and mx6dl (duallite) processor.
> > 
> > Now fdt_file hardcoded value can be removed.
> > 
> > Signed-off-by: Troy Kisky <troy.kisky@boundarydevices.com>
> 
> Nice! I do think it is in the right direction. I will give it a try soon...

Full NAK on this patch, I completely agree with Eric that this approach is 
totally wrong. This adds stuff which should be pulled from DT into common code, 
this is just NAK.

Best regards,
Marek Vasut

  reply	other threads:[~2014-03-30 14:52 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-29 22:34 [U-Boot] [PATCH 1/1] imx-common: cpu: add fdt_file environment variable Troy Kisky
2014-03-29 23:04 ` Otavio Salvador
2014-03-30 14:52   ` Marek Vasut [this message]
2014-03-31 18:30     ` Troy Kisky
2014-03-29 23:11 ` Eric Nelson
2014-03-31 18:36   ` Troy Kisky
2014-03-31 19:22     ` Marek Vasut
2014-03-31 19:38       ` Otavio Salvador
2014-03-31 19:47         ` Marek Vasut
2014-03-31 21:09           ` Troy Kisky
2014-04-01  7:45             ` Marek Vasut
2014-03-30 16:30 ` Stefano Babic
2014-03-31 18:29   ` Troy Kisky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201403301652.36385.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox