From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric =?UTF-8?B?QsOpbmFyZA==?= Date: Mon, 31 Mar 2014 22:02:34 +0200 Subject: [U-Boot] [PATCH v4 1/2] RiOTboard: add new board In-Reply-To: <53384461.40904@denx.de> References: <20140328100130.1605B38233A@gemini.denx.de> <1396128580-11129-1-git-send-email-eric@eukrea.com> <53384461.40904@denx.de> Message-ID: <20140331220234.0b2ec49e@e6520eb> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Stefano, Le Sun, 30 Mar 2014 18:20:49 +0200, Stefano Babic a ?crit : > A general remark. I agree by reading the whole thread about checking at > runtime which is the running board (you do it getting the cpu type). > > However, you use also a compiler switch mechanism, adding RIOTBOARD or > MARSBOARD in the boards.cfg. You have implemented two ways to for the > same thing. This makes in principle your runtime detection useless, > because you can use #if CONFIG_MARSBOARD instead of "if board_type == > BOARD_IS_MARSBOARD)". Is it possible to use only the runtime detection ? > I think the main problem is CONFIG_ENV_IS_*, that is different for the > two boards. What do you think about it ? > I've tried and I don't see how to include functions to handle both MMC and SF environment in the same binary with the current env code. A workaround would be to use MMC to store env also on the MarSBoard but as it is using the SPI flash as the boot source I would prefer to keep the env in the SPI flash. Best regards, Eric