[U-Boot] [PATCH 2/3] dfu: add static alt num count in dfu_config_entities()

Lukasz Majewski
2014-03-31T09:15:48Z

Hi Marek,

> On Monday, March 31, 2014 at 10:48:48 AM, Lukasz Majewski wrote:
> > From: Przemyslaw Marczak <p.marczak@samsung.com>
> >
> > Thanks to this multiple calls of function dfu_config_entities() give
> > continuous dfu alt numbering until call dfu_free_entities().
> >
> > This allows to store dfu entities in multiple env variables.
> >
> > Change-Id: Ibca7e785bfca9f53b64d3dff0490185b06841b54
> > Signed-off-by: Przemyslaw Marczak <p.marczak@samsung.com>
> > ---
> > drivers/dfu/dfu.c | 6 +++++-
> > 1 file changed, 5 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/dfu/dfu.c b/drivers/dfu/dfu.c
> > index f94c412..e15f959 100644
> > --- a/drivers/dfu/dfu.c
> > +++ b/drivers/dfu/dfu.c
> > @@ -19,6 +19,7 @@
> > static bool dfu_reset_request;
> > static LIST_HEAD(dfu_list);
> > static int dfu_alt_num;
> > +static int alt_num_count;
>
> Can the variable name here be any less consistent with the
> rest ... ? ;-)

I think, that something like dfu_alt_num_cnt would fit better there.

>
> [...]
>
> Best regards,
> Marek Vasut

--
Best regards,

Lukasz Majewski

Samsung R&D Institute Poland (SRPOL) | Linux Platform Group