public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] arm: mxs: Add serial console support into SPL
Date: Wed, 2 Apr 2014 10:45:55 +0200	[thread overview]
Message-ID: <201404021045.55683.marex@denx.de> (raw)
In-Reply-To: <533BCDDC.3030809@denx.de>

On Wednesday, April 02, 2014 at 10:44:12 AM, Stefano Babic wrote:
> On 01/04/2014 10:47, Marek Vasut wrote:
> > On Tuesday, April 01, 2014 at 10:34:38 AM, Stefano Babic wrote:
> >> On 19/03/2014 02:21, Marek Vasut wrote:
> >>> Add support for serial console into the i.MX23/i.MX28 SPL. A full,
> >>> uncrippled serial console support comes very helpful when debugging
> >>> various spectacular hardware bringup issues early in the process.
> >>> Because we do not use SPL framework, but have our own minimalistic
> >>> SPL, which is compatible with the i.MX23/i.MX28 BootROM, we do not
> >>> use preloader_console_init(), but instead use a similar function to
> >>> start the console. Nonetheless, to avoid blowing up the size of the
> >>> SPL binary, this support is enabled only if CONFIG_SPL_SERIAL_SUPPORT
> >>> is defined, which is disabled by default.
> >>> 
> >>> Signed-off-by: Marek Vasut <marex@denx.de>
> >>> Cc: Stefano Babic <sbabic@denx.de>
> >>> ---
> >> 
> >> Applied after fixing warning:
> >> 
> >> arch/arm/cpu/arm926ejs/mxs/spl_boot.c:22:13: warning: 'bdata' defined
> >> but not used
> > 
> > Tsk, stupid me. Thanks!
> 
> No, stupid me ! I pushed the tree before fixing your patch. I had to add
> the simple fix as separate commit, it was not my intention.

Everything is crap! (TM) :-)

Best regards,
Marek Vasut

  reply	other threads:[~2014-04-02  8:45 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-19  1:21 [U-Boot] [PATCH 1/2] arm: mxs: Properly set GD pointer in SPL Marek Vasut
2014-03-19  1:21 ` [U-Boot] [PATCH 2/2] arm: mxs: Add serial console support into SPL Marek Vasut
2014-04-01  8:34   ` Stefano Babic
2014-04-01  8:47     ` Marek Vasut
2014-04-02  8:44       ` Stefano Babic
2014-04-02  8:45         ` Marek Vasut [this message]
2014-04-01  8:34 ` [U-Boot] [PATCH 1/2] arm: mxs: Properly set GD pointer in SPL Stefano Babic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201404021045.55683.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox