[U-Boot] [PATCH] usb: ehci: rmobile: Add support ehci host driver of rmobile SoCs

Nobuhiro Iwamatsu
2014-04-03T02:27:13Z

Hi,

Thanks for your review.

2014-04-03 7:25 GMT+09:00 Marek Vasut <marex@denx.de>:
> On Wednesday, April 02, 2014 at 06:29:03 AM, Nobuhiro Iwamatsu wrote:
>> The rmobile SoC has usb host controller.
>> This supports USB controllers listed in the R8A7790, R8A7791 and R8A7740.
>>
>> Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
>> ---
>> arch/arm/include/asm/arch-rmobile/ehci-rmobile.h | 169
>> +++++++++++++++++++++++ drivers/usb/host/Makefile |
>> 1 +
>> drivers/usb/host/ehci-rmobile.c | 109 +++++++++++++++
>> 3 files changed, 279 insertions(+)
>> create mode 100644 arch/arm/include/asm/arch-rmobile/ehci-rmobile.h
>> create mode 100644 drivers/usb/host/ehci-rmobile.c
>
> [...]
>
>> +#define PHYS_OFFSET CONFIG_SYS_SDRAM_BASE
>
> This is a bit creepy, is this really necessary ?

I see. I will remove PHYS_OFFSET, and use CONFIG_SYS_SDRAM_BASE instead of this.
I will re-send.

>
> As for the rest:
>
> Reviewed-by: Marek Vasut <marex@denx.de>

Thanks!

>
> Best regards,
> Marek Vasut

Best regards,
Nobuhiro

--
Nobuhiro Iwamatsu