public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Gerhard Sittig <gsi@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v6 2/9] tools: mkimage: add support for gpimage format
Date: Mon, 7 Apr 2014 15:21:35 +0200	[thread overview]
Message-ID: <20140407132135.GC11339@book.gsilab.sittig.org> (raw)
In-Reply-To: <20140404204515.C63C8383409@gemini.denx.de>

On Fri, 2014-04-04 at 22:45 +0200, Wolfgang Denk wrote:
> 
> Dear Murali Karicheri,
> 
> In message <1396631815-5735-3-git-send-email-m-karicheri2@ti.com> you wrote:
> > This patch add support for gpimage format as a preparatory
> > patch for porting u-boot for keystone2 devices and is
> > based on omapimage format. It re-uses gph header to store the
> > size and loadaddr as done in omapimage.c
> ...
> > @@ -125,6 +125,7 @@ static const table_entry_t uimage_type[] = {
> >  	{	IH_TYPE_FILESYSTEM, "filesystem", "Filesystem Image",	},
> >  	{	IH_TYPE_FIRMWARE,   "firmware",	  "Firmware",		},
> >  	{	IH_TYPE_FLATDT,     "flat_dt",    "Flat Device Tree",	},
> > +	{	IH_TYPE_GPIMAGE,    "gpimage",    "TI Keystone SPL Image",},
> >  	{	IH_TYPE_KERNEL,	    "kernel",	  "Kernel Image",	},
> >  	{	IH_TYPE_KERNEL_NOLOAD, "kernel_noload",  "Kernel Image (no loading done)", },
> >  	{	IH_TYPE_KWBIMAGE,   "kwbimage",   "Kirkwood Boot Image",},
> 
> For binary compatibility with existing images you can only appen, but
> never insert into uimage_type[].

the next hunk (declaration of the IH_TYPE_GPIMAGE enum value) did
the append, using a number past all previously used numbers,
keeping compatibility with existing binaries

the above hunk just references the newly introduced enum, and
keeps the list of images sorted alphabetically -- so I think this
is OK


virtually yours
Gerhard Sittig
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr. 5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de

  reply	other threads:[~2014-04-07 13:21 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-04 17:16 [U-Boot] [PATCH v6 0/9] Add support for keystone2 SoC and K2HK EVM Murali Karicheri
2014-04-04 17:16 ` [U-Boot] [PATCH v6 1/9] fdt: call ft_board_setup_ex() at the end of image_setup_libfdt() Murali Karicheri
2014-04-04 17:16 ` [U-Boot] [PATCH v6 2/9] tools: mkimage: add support for gpimage format Murali Karicheri
2014-04-04 20:45   ` Wolfgang Denk
2014-04-07 13:21     ` Gerhard Sittig [this message]
2014-04-07 13:55       ` Tom Rini
2014-04-07 17:01         ` Wolfgang Denk
2014-04-04 17:16 ` [U-Boot] [PATCH v6 3/9] arm: add support for arch timer Murali Karicheri
2014-04-04 17:16 ` [U-Boot] [PATCH v6 4/9] NAND: DaVinci: allow forced disable of subpage writes Murali Karicheri
2014-04-04 17:16 ` [U-Boot] [PATCH v6 5/9] i2c, davinci: move i2c_defs.h to the drivers/i2c directory Murali Karicheri
2014-04-04 17:16 ` [U-Boot] [PATCH v6 6/9] i2c, davinci: convert driver to new mutlibus/mutliadapter framework Murali Karicheri
2014-04-04 17:16 ` [U-Boot] [PATCH v6 7/9] k2hk: add support for k2hk SOC and EVM Murali Karicheri
2014-04-04 17:16 ` [U-Boot] [PATCH v6 8/9] spi: davinci: add support for multiple bus and chip select Murali Karicheri
2014-04-07  7:09   ` Jagan Teki
2014-04-04 17:16 ` [U-Boot] [PATCH v6 9/9] k2hk-evm: add configuration for spi1 and spi2 support Murali Karicheri
2014-04-18 13:24 ` [U-Boot] [PATCH v6 0/9] Add support for keystone2 SoC and K2HK EVM Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140407132135.GC11339@book.gsilab.sittig.org \
    --to=gsi@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox