From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Mon, 7 Apr 2014 09:55:02 -0400 Subject: [U-Boot] [PATCH v6 2/9] tools: mkimage: add support for gpimage format In-Reply-To: <20140407132135.GC11339@book.gsilab.sittig.org> References: <1396631815-5735-1-git-send-email-m-karicheri2@ti.com> <1396631815-5735-3-git-send-email-m-karicheri2@ti.com> <20140404204515.C63C8383409@gemini.denx.de> <20140407132135.GC11339@book.gsilab.sittig.org> Message-ID: <20140407135502.GB23803@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Mon, Apr 07, 2014 at 03:21:35PM +0200, Gerhard Sittig wrote: > On Fri, 2014-04-04 at 22:45 +0200, Wolfgang Denk wrote: > > > > Dear Murali Karicheri, > > > > In message <1396631815-5735-3-git-send-email-m-karicheri2@ti.com> you wrote: > > > This patch add support for gpimage format as a preparatory > > > patch for porting u-boot for keystone2 devices and is > > > based on omapimage format. It re-uses gph header to store the > > > size and loadaddr as done in omapimage.c > > ... > > > @@ -125,6 +125,7 @@ static const table_entry_t uimage_type[] = { > > > { IH_TYPE_FILESYSTEM, "filesystem", "Filesystem Image", }, > > > { IH_TYPE_FIRMWARE, "firmware", "Firmware", }, > > > { IH_TYPE_FLATDT, "flat_dt", "Flat Device Tree", }, > > > + { IH_TYPE_GPIMAGE, "gpimage", "TI Keystone SPL Image",}, > > > { IH_TYPE_KERNEL, "kernel", "Kernel Image", }, > > > { IH_TYPE_KERNEL_NOLOAD, "kernel_noload", "Kernel Image (no loading done)", }, > > > { IH_TYPE_KWBIMAGE, "kwbimage", "Kirkwood Boot Image",}, > > > > For binary compatibility with existing images you can only appen, but > > never insert into uimage_type[]. > > the next hunk (declaration of the IH_TYPE_GPIMAGE enum value) did > the append, using a number past all previously used numbers, > keeping compatibility with existing binaries > > the above hunk just references the newly introduced enum, and > keeps the list of images sorted alphabetically -- so I think this > is OK Yes, agreed. -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: