From mboxrd@z Thu Jan  1 00:00:00 1970
From: Lukasz Majewski <l.majewski@samsung.com>
Date: Wed, 09 Apr 2014 15:02:58 +0200
Subject: [U-Boot] [PATCH] arm:board:trats2:FIX: Clear INFORM4 and
 INFORM5 registers at correct boot
In-Reply-To: <5345442D.5030604@samsung.com>
References: <1397047297-15781-1-git-send-email-l.majewski@samsung.com>
	<5345442D.5030604@samsung.com>
Message-ID: <20140409150258.2c3211cd@amdc2363>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Minkyu,

> Dear Lukasz Majewski,
> 
> On 09/04/14 21:41, Lukasz Majewski wrote:
> > During switch to device tree, commit 1ecab0f has removed this code.
> > 
> > INFORM4 and INFORM5 registers are used by TRATS2 first stage
> > bootloader for providing recovery. For normal operation, those two
> > must be cleared out.
> > 
> > This error emerges when one force reset from u-boot's command line
> > for three times.
> > 
> > Signed-off-by: Lukasz Majewski <l.majewski@samsung.com>
> > Cc: Minkyu Kang <mk7.kang@samsung.com>
> > ---
> >  board/samsung/trats2/trats2.c |   13 +++++++++++++
> >  1 file changed, 13 insertions(+)
> > 
> > diff --git a/board/samsung/trats2/trats2.c
> > b/board/samsung/trats2/trats2.c index 2a6c9f9..75a6c7b 100644
> > --- a/board/samsung/trats2/trats2.c
> > +++ b/board/samsung/trats2/trats2.c
> > @@ -150,9 +150,22 @@ static int pmic_init_max77686(void);
> >  
> >  int exynos_init(void)
> >  {
> > +	struct exynos4_power *pwr =
> > +		(struct exynos4_power *)samsung_get_base_power();
> > +
> >  	check_hw_revision();
> >  	printf("HW Revision:\t0x%04x\n", board_rev);
> >  
> > +	/*
> > +	 * First bootloader on the TRATS2 platform uses
> > +	 * INFORM4 and INFORM5 registers for recovery
> > +	 *
> > +	 * To indicate correct boot chain - those two
> > +	 * registers must be cleared out
> > +	 */
> > +	writel(0, (unsigned int)&pwr->inform4);
> > +	writel(0, (unsigned int)&pwr->inform5);
> 
> I think, you don't have to do type casting.

You are right, thanks for pointing out.

> 
> > +
> >  	return 0;
> >  }
> >  
> > 
> 
> Thanks,
> Minkyu Kang.



-- 
Best regards,

Lukasz Majewski

Samsung R&D Institute Poland (SRPOL) | Linux Platform Group