public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Enable big-endian processors to use EHCI interrupt transfers
Date: Thu, 10 Apr 2014 09:59:38 +0200	[thread overview]
Message-ID: <201404100959.38676.marex@denx.de> (raw)
In-Reply-To: <20140409220302.a0167f244ed3533814391094@humboldt.co.uk>

On Wednesday, April 09, 2014 at 11:03:02 PM, Adrian Cox wrote:
> Add endian support macros to interrupt transfers in the EHCI driver, to
> allow operation on PowerPC.
> 
> Signed-off-by: Adrian Cox <adrian@humboldt.co.uk>

Other than style issues, which need to be fixes (you can check for them with 
./scripts/checkpatch.pl /path/to/your/0001-patch.patch) :

WARNING: line over 80 characters
#103: FILE: drivers/usb/host/ehci-hcd.c:1193:
+               qh->qh_endpt1 = cpu_to_hc32((0 << 28) | /* No NAK reload (ehci 
4.9) */

WARNING: line over 80 characters
#141: FILE: drivers/usb/host/ehci-hcd.c:1217:
+               td->qt_buffer[0] = cpu_to_hc32((uint32_t)buffer + i * 
elementsize);

WARNING: line over 80 characters
#142: FILE: drivers/usb/host/ehci-hcd.c:1218:
+               td->qt_buffer[1] = cpu_to_hc32((td->qt_buffer[0] + 0x1000) & 
~0xfff);

WARNING: line over 80 characters
#143: FILE: drivers/usb/host/ehci-hcd.c:1219:
+               td->qt_buffer[2] = cpu_to_hc32((td->qt_buffer[0] + 0x2000) & 
~0xfff);

WARNING: line over 80 characters
#144: FILE: drivers/usb/host/ehci-hcd.c:1220:
+               td->qt_buffer[3] = cpu_to_hc32((td->qt_buffer[0] + 0x3000) & 
~0xfff);

WARNING: line over 80 characters
#145: FILE: drivers/usb/host/ehci-hcd.c:1221:
+               td->qt_buffer[4] = cpu_to_hc32((td->qt_buffer[0] + 0x4000) & 
~0xfff);

total: 0 errors, 6 warnings, 0 checks, 102 lines checked

NOTE: Ignored message types: COMPLEX_MACRO CONSIDER_KSTRTO MINMAX 
MULTISTATEMENT_MACRO_USE_DO_WHILE NETWORKING_BLOCK_COMMENT_STYLE USLEEP_RANGE

Reviewed-by: Marek Vasut <marex@denx.de>

Also, use:

$ git format-patch HEAD~1 -o /path/to/your/patch
$ git send-email --annotate --to=u-boot..... /path/to/your/patch/00*.patch

Best regards,
Marek Vasut

  reply	other threads:[~2014-04-10  7:59 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-09 21:03 [U-Boot] [PATCH] Enable big-endian processors to use EHCI interrupt transfers Adrian Cox
2014-04-10  7:59 ` Marek Vasut [this message]
  -- strict thread matches above, loose matches on Subject: below --
2014-04-09 21:03 Adrian Cox
2014-04-09 21:08 ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201404100959.38676.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox