From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Fix USB keyboard polling via control endpoint
Date: Thu, 10 Apr 2014 11:04:27 +0200 [thread overview]
Message-ID: <201404101104.27820.marex@denx.de> (raw)
In-Reply-To: <6362080.176.1397119795614.JavaMail.adrian@Gurnard>
On Thursday, April 10, 2014 at 10:49:56 AM, Adrian Cox wrote:
> > From: "Marek Vasut" <marex@denx.de>
> >
> > Also, this USB_KBD_PDATA_SIZE should instead be called
> > "USB_KBD_LS_REPORT_SIZE"
> > [...]
> > What worries me a bit is that 64-byte high-speed report, but I never
> > saw a
> > device that would generate those. This section 5.6 is also the only
> > place that
> > mentions the high-speed HID device report size limit.
>
> How about renaming to USB_KBD_BOOT_REPORT_SIZE? We know that the keyboard
> report will be 8 bytes because we explicitly set the keyboard into boot
> protocol (Appendix B of HID 1.11: "The report may not exceed 8 bytes in
> length.").
Good point, thanks. A comment in the code about where this number '8' comes from
would be nice.
Best regards,
Marek Vasut
next prev parent reply other threads:[~2014-04-10 9:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <13471364.2645.1396715619854.JavaMail.adrian@Gurnard>
2014-04-05 16:36 ` [U-Boot] [PATCH] Fix USB keyboard polling via control endpoint Adrian Cox
2014-04-06 11:17 ` Wolfgang Denk
2014-04-07 9:56 ` Adrian Cox
2014-04-07 16:59 ` Wolfgang Denk
2014-04-10 8:12 ` Marek Vasut
2014-04-10 8:49 ` Adrian Cox
2014-04-10 9:04 ` Marek Vasut [this message]
2014-04-10 10:15 ` Wolfgang Denk
2014-04-10 12:33 ` Marek Vasut
2014-04-10 13:02 ` [U-Boot] [PATCH v3] " Adrian Cox
2014-04-10 14:14 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201404101104.27820.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox