[U-Boot] [PATCH v3 4/5] usb/gadget: add the fastboot gadget

Rob Herring
2014-04-11T12:55:31Z

On Fri, Apr 11, 2014 at 2:14 AM, Bo Shen <voice.shen@atmel.com> wrote:
> Hi Rob Herring,
> I am just do a function testing on Atmel sama5d3xek board. And a small
> comment as following.
>
> Btw, do you test to transfer big size file. I try a file bigger than
> 100MiB, it will hang. However use DFU or RNDIS don't meet this issue.

How much RAM do you have? It will happily download into the end of RAM
overwriting u-boot if loadsize is not set. DFU at least has its own
buffer size configuration.

>
>
> On 04/11/2014 03:18 AM, Rob Herring wrote:
>>
>> +static void fastboot_unbind(struct usb_gadget *gadget)
>> +{
>> + usb_ep_free_request(gadget->ep0, ep0_req);
>> + ep_in->driver_data = NULL;
>> + ep_out->driver_data = NULL;
>> +
>> + gadget_is_connected = 0;
>> + usb_gadget_disconnect(gadget);
>> +}
>
>
> [snip]
>
>
>> +static void fastboot_disconnect(struct usb_gadget *gadget)
>> +{
>> + fastboot_disable_ep(gadget);
>> + gadget_is_connected = 0;
>
>
> Do this only in unbind, as unbind is really disconnect.

So, what should disconnect function do?

Rob