[U-Boot] [PATCH 1/2] usb: r8a66597: Fix initialization hub that using, R8A66597_MAX_ROOT_HUB

Marek Vasut
2014-04-18T13:57:25Z

On Friday, April 18, 2014 at 04:25:41 AM, Yasuhisa Umano wrote:
> Hi,
> Thanks for your comment.
>
> (2014/04/17 23:07), Marek Vasut wrote:
> > On Thursday, April 17, 2014 at 09:48:32 AM, yasuhisa umano wrote:
> >> This driver is processed as two USB hub despite one.
> >> The number of root hub is defined in R8A66597_MAX_ROOT_HUB.
> >> This fixes that register is accessed by using the definition
> >> of R8A66597_MAX_ROOT_HUB.
> >>
> >> Signed-off-by: Yasuhisa Umano <yasuhisa.umano.zc@renesas.com>
> >> ---
> >>
> >> drivers/usb/host/r8a66597-hcd.c | 4 ++--
> >> 1 file changed, 2 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/drivers/usb/host/r8a66597-hcd.c
> >> b/drivers/usb/host/r8a66597-hcd.c index dfe5423..c58d2a9 100644
> >> --- a/drivers/usb/host/r8a66597-hcd.c
> >> +++ b/drivers/usb/host/r8a66597-hcd.c
> >> @@ -164,8 +164,8 @@ static int enable_controller(struct r8a66597
> >> *r8a66597)
> >>
> >> r8a66597_bset(r8a66597, INTL, SOFCFG);
> >> r8a66597_write(r8a66597, 0, INTENB0);
> >>
> >> - r8a66597_write(r8a66597, 0, INTENB1);
> >> - r8a66597_write(r8a66597, 0, INTENB2);
> >> + for (port = 0; port < R8A66597_MAX_ROOT_HUB; port++)
> >> + r8a66597_write(r8a66597, 0, get_intenb_reg(port));
> >
> > Hmm, looking at get_intenb_reg(), this is slightly dangerous, but I will
> > trust you you know what you are doing . I am a bit worried someone might
> > set R8A66597_MAX_ROOT_HUB to value >2 and will wonder why doesn't it
> > work.
>
> I understood your point.
> Certainly, current?device drivers support only the initialization of 1 or 2
> interrupt for hub.
> If this driver has a hub of more future, I will send the patch.

Thanks

Best regards,
Marek Vasut