public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Masahiro Yamada <yamada.m@jp.panasonic.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/5] blackfin: replace bfin_gen_rand_mac() with eth_random_addr()
Date: Fri, 18 Apr 2014 18:25:56 +0900	[thread overview]
Message-ID: <20140418182556.F07D.AA925319@jp.panasonic.com> (raw)
In-Reply-To: <2417898.IToALaZWXa@vapier>

Hi Mike,

On Thu, 17 Apr 2014 15:07:50 -0400
Mike Frysinger <vapier@gentoo.org> wrote:

> On Thu 17 Apr 2014 17:00:30 Masahiro Yamada wrote:
> > --- a/include/configs/tcm-bf537.h
> > +++ b/include/configs/tcm-bf537.h
> > @@ -73,7 +73,7 @@
> >  #define CONFIG_HOSTNAME		tcm-bf537
> >  /* Uncomment next line to use fixed MAC address */
> >  /* #define CONFIG_ETHADDR	02:80:ad:20:31:e8 */
> > -
> > +#define CONFIG_LIB_RAND
> 
> this should be in bfin_adi_common.h instead.  i think that replaces the 
> majority of your config updates (if not all).
> -mike

Are you sure?

There are 35 blackfin boards in boards.cfg.
There are only 15 boards using random MAC address.


Besides, I think your suggestion does not work
because for ex.  bf537-minotaur board is not including bfin_adi_common.h.




Best Regards
Masahiro Yamada

  reply	other threads:[~2014-04-18  9:25 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-17  8:00 [U-Boot] [PATCH 0/5] Do not use __DATE__ and __TIME__ anymore Masahiro Yamada
2014-04-17  8:00 ` [U-Boot] [PATCH 1/5] rand: do not surround function declarations by #ifdef Masahiro Yamada
2014-04-17  8:00 ` [U-Boot] [PATCH 2/5] net: rename and refactor eth_rand_ethaddr() function Masahiro Yamada
2014-04-17  8:08   ` Joe Hershberger
2014-04-17 11:09   ` Wolfgang Denk
2014-04-17  8:00 ` [U-Boot] [PATCH 3/5] blackfin: replace bfin_gen_rand_mac() with eth_random_addr() Masahiro Yamada
2014-04-17 19:07   ` Mike Frysinger
2014-04-18  9:25     ` Masahiro Yamada [this message]
2014-04-17  8:00 ` [U-Boot] [PATCH 4/5] fs: ubifs: drop __DATE__ and __TIME__ Masahiro Yamada
2014-04-17  8:00 ` [U-Boot] [PATCH 5/5] kbuild: build with -Werror=date-time if the compiler supports it Masahiro Yamada
2014-04-17 11:07 ` [U-Boot] [PATCH 0/5] Do not use __DATE__ and __TIME__ anymore Wolfgang Denk
2014-04-17 11:41   ` Masahiro Yamada
2014-04-17 14:48     ` Wolfgang Denk
2014-04-17 19:10 ` Mike Frysinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140418182556.F07D.AA925319@jp.panasonic.com \
    --to=yamada.m@jp.panasonic.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox