From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Fri, 18 Apr 2014 17:02:05 -0400 Subject: [U-Boot] [U-Boot, 3/3] pcnet: force ordering of descriptor accesses In-Reply-To: <1396885308-61884-4-git-send-email-paul.burton@imgtec.com> References: <1396885308-61884-4-git-send-email-paul.burton@imgtec.com> Message-ID: <20140418210205.GA5698@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Mon, Apr 07, 2014 at 04:41:48PM +0100, Paul Burton wrote: > The ordering of accesses to the rx & tx descriptors is important, yet > the send & recv functions accessed them via regular structure accesses. > This leaves the compiler with the opportunity to reorder those accesses > or to hoist them outside of loops. Prevent that from happening by using > readl & writel to access the descriptors. As a nice bonus, this removes > the need for the driver to care about endianness. > > Signed-off-by: Paul Burton Applied to u-boot/master, thanks! -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: