From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v4 0/5] Android Fastboot support
Date: Mon, 21 Apr 2014 17:13:33 +0200 [thread overview]
Message-ID: <201404211713.34077.marex@denx.de> (raw)
In-Reply-To: <20140418161426.F0B863804B6@gemini.denx.de>
On Friday, April 18, 2014 at 06:14:26 PM, Wolfgang Denk wrote:
> Dear Rob,
>
> In message <1397829272-22266-1-git-send-email-robherring2@gmail.com> you
wrote:
> > I dropped the patch adding a loadsize env variable and added config
> > uptions instead to set the fastboot buffer size.
>
> Thanks, but...
>
> > common/Makefile | 3 +
> > common/cmd_bootm.c | 23 +-
> > common/cmd_fastboot.c | 36 +++
> > common/image-android.c | 84 ++++++
> > common/image.c | 20 +-
> > doc/README.android-fastboot | 91 ++++++
> > doc/README.android-fastboot-protocol | 170 ++++++++++++
> > drivers/usb/gadget/Makefile | 1 +
> > drivers/usb/gadget/f_fastboot.c | 518
> > +++++++++++++++++++++++++++++++++++ drivers/usb/gadget/g_dnl.c
> > | 6 +
> > drivers/usb/gadget/usbstring.c | 3 +
> > drivers/usb/musb-new/musb_uboot.c | 5 +-
> > include/android_image.h | 69 +++++
> > include/configs/omap3_beagle.h | 10 +
> > include/fastboot.h | 22 ++
> > include/image.h | 13 +
> > 16 files changed, 1067 insertions(+), 7 deletions(-)
>
> ...I don't see the README in the list of modified files - but new
> CONFIG options _must_ be documented there. So please add the missing
> documentation.
I reviewed the patches again. I am with WD on this, please add the changes to
the README file.
Other than that, I applied 1/5 and 3/5 now as they are clearly fixes and can go
in. Please rebase on top of u-boot-usb/master and re-submit the rest.
Thanks!
Best regards,
Marek Vasut
next prev parent reply other threads:[~2014-04-21 15:13 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-10 19:18 [U-Boot] [PATCH v3 0/5] Android Fastboot support Rob Herring
2014-04-10 19:18 ` [U-Boot] [PATCH v3 1/5] common: introduce maximum load size Rob Herring
2014-04-11 14:46 ` Tom Rini
2014-04-15 12:55 ` Lukasz Majewski
2014-04-15 21:59 ` Wolfgang Denk
2014-04-15 23:54 ` Rob Herring
2014-04-16 7:27 ` Wolfgang Denk
2014-04-10 19:18 ` [U-Boot] [PATCH v3 2/5] usb: handle NULL table in usb_gadget_get_string Rob Herring
2014-04-11 14:46 ` Tom Rini
2014-04-11 21:39 ` Marek Vasut
2014-04-15 13:00 ` Lukasz Majewski
2014-04-10 19:18 ` [U-Boot] [PATCH v3 3/5] image: add support for Android's boot image format Rob Herring
2014-04-11 14:46 ` Tom Rini
2014-04-11 21:44 ` Marek Vasut
2014-04-12 21:54 ` Rob Herring
2014-04-13 16:55 ` Marek Vasut
2014-04-15 13:59 ` Lukasz Majewski
2014-04-10 19:18 ` [U-Boot] [PATCH v3 4/5] usb/gadget: add the fastboot gadget Rob Herring
2014-04-11 7:14 ` Bo Shen
2014-04-11 12:55 ` Rob Herring
2014-04-11 22:13 ` Marek Vasut
2014-04-14 6:51 ` Lukasz Majewski
2014-04-14 2:28 ` Bo Shen
2014-04-11 7:30 ` Lukasz Majewski
2014-04-11 14:46 ` Tom Rini
2014-04-11 22:08 ` Marek Vasut
2014-04-15 15:41 ` Lukasz Majewski
2014-04-15 16:01 ` Rob Herring
2014-04-10 19:18 ` [U-Boot] [PATCH v3 5/5] arm: beagle: enable Android fastboot support Rob Herring
2014-04-11 14:46 ` Tom Rini
2014-04-10 19:18 ` [U-Boot] [PATCH 5/5] beagle: " Rob Herring
2014-04-10 19:42 ` Rob Herring
2014-04-11 7:04 ` [U-Boot] [PATCH v3 0/5] Android Fastboot support Sebastian Andrzej Siewior
2014-04-11 14:15 ` Tom Rini
2014-04-11 14:45 ` Tom Rini
2014-04-14 12:19 ` Rob Herring
2014-04-18 13:54 ` [U-Boot] [PATCH v4 " Rob Herring
2014-04-18 13:54 ` [U-Boot] [PATCH v4 1/5] usb: handle NULL table in usb_gadget_get_string Rob Herring
2014-04-18 13:54 ` [U-Boot] [PATCH v4 2/5] image: add support for Android's boot image format Rob Herring
2014-04-18 13:54 ` [U-Boot] [PATCH v4 3/5] usb: musb: fill in usb_gadget_unregister_driver Rob Herring
2014-04-23 9:46 ` Lukasz Majewski
2014-04-18 13:54 ` [U-Boot] [PATCH v4 4/5] usb/gadget: add the fastboot gadget Rob Herring
2014-04-23 11:02 ` Lukasz Majewski
2014-04-23 12:25 ` Marek Vasut
2014-04-24 15:02 ` Rob Herring
2014-04-25 5:26 ` Lukasz Majewski
2014-04-25 13:30 ` Rob Herring
2014-04-28 7:00 ` Lukasz Majewski
2014-04-18 13:54 ` [U-Boot] [PATCH v4 5/5] arm: beagle: enable Android fastboot support Rob Herring
2014-04-18 16:14 ` [U-Boot] [PATCH v4 0/5] Android Fastboot support Wolfgang Denk
2014-04-21 15:13 ` Marek Vasut [this message]
2014-04-23 14:36 ` Rob Herring
2014-04-23 16:57 ` Marek Vasut
2014-05-05 20:08 ` [U-Boot] [PATCH v5 0/3] " Rob Herring
2014-05-05 20:08 ` [U-Boot] [PATCH v5 1/3] image: add support for Android's boot image format Rob Herring
2014-05-05 20:08 ` [U-Boot] [PATCH v5 2/3] usb/gadget: add the fastboot gadget Rob Herring
2014-05-05 20:08 ` [U-Boot] [PATCH v5 3/3] arm: beagle: enable Android fastboot support Rob Herring
2014-05-05 20:21 ` [U-Boot] [PATCH v5 0/3] Android Fastboot support Marek Vasut
2014-05-07 6:35 ` Lukasz Majewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201404211713.34077.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox