From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] exynos: usb: Fix data abort on boards w/o vbus-gpio node in the DT
Date: Wed, 23 Apr 2014 15:17:59 +0200 [thread overview]
Message-ID: <201404231517.59497.marex@denx.de> (raw)
In-Reply-To: <1398187429-15199-1-git-send-email-andrey.konovalov@linaro.org>
On Tuesday, April 22, 2014 at 07:23:49 PM, andrey.konovalov at linaro.org wrote:
> Commit 4a271cb1b4ff doesn't take into account that fdtdec_setup_gpio()
> returns success when the gpio passed to it is FDT_GPIO_NONE (no
> gpio node found in the fdtdec_decode_gpio() call). This results in
> calling gpio_direction_output() on invalid gpio. For this reason
> executing "usb start" command on Arndale causes data abort in the
> ehci-exynos driver.
>
> Add the fdt_gpio_isvalid() check to fix that problem.
>
> Signed-off-by: Andrey Konovalov <andrey.konovalov@linaro.org>
> Cc: Julius Werner <jwerner@chromium.org>
> Cc: Simon Glass <sjg@chromium.org>
> Cc: Minkyu Kang <mk7.kang@samsung.com>
> Cc: Marek Vasut <marex@denx.de>
Applied, thanks.
Best regards,
Marek Vasut
prev parent reply other threads:[~2014-04-23 13:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-22 17:23 [U-Boot] [PATCH] exynos: usb: Fix data abort on boards w/o vbus-gpio node in the DT andrey.konovalov at linaro.org
2014-04-23 13:17 ` Marek Vasut [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201404231517.59497.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox