From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Wed, 23 Apr 2014 15:17:59 +0200 Subject: [U-Boot] [PATCH] exynos: usb: Fix data abort on boards w/o vbus-gpio node in the DT In-Reply-To: <1398187429-15199-1-git-send-email-andrey.konovalov@linaro.org> References: <1398187429-15199-1-git-send-email-andrey.konovalov@linaro.org> Message-ID: <201404231517.59497.marex@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Tuesday, April 22, 2014 at 07:23:49 PM, andrey.konovalov at linaro.org wrote: > Commit 4a271cb1b4ff doesn't take into account that fdtdec_setup_gpio() > returns success when the gpio passed to it is FDT_GPIO_NONE (no > gpio node found in the fdtdec_decode_gpio() call). This results in > calling gpio_direction_output() on invalid gpio. For this reason > executing "usb start" command on Arndale causes data abort in the > ehci-exynos driver. > > Add the fdt_gpio_isvalid() check to fix that problem. > > Signed-off-by: Andrey Konovalov > Cc: Julius Werner > Cc: Simon Glass > Cc: Minkyu Kang > Cc: Marek Vasut Applied, thanks. Best regards, Marek Vasut