public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Masahiro Yamada <yamada.m@jp.panasonic.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RFC PATCH 1/3] env: drop CONFIG_ENV_VARS_UBOOT_CONFIG support
Date: Wed, 23 Apr 2014 21:03:35 +0900	[thread overview]
Message-ID: <20140423210335.18EE.AA925319@jp.panasonic.com> (raw)
In-Reply-To: <20140422121345.04ABA3801AC@gemini.denx.de>

Hi Wolfgang,


On Tue, 22 Apr 2014 14:13:44 +0200
Wolfgang Denk <wd@denx.de> wrote:

> Dear Masahiro,
> 
> In message <1398159826-29398-2-git-send-email-yamada.m@jp.panasonic.com> you wrote:
> > CONFIG_ENV_VARS_UBOOT_CONFIG, if defined, sets environment
> > variables, "arch", "cpu", "board", etc. depending on
> > CONFIG_SYS_ARCH, CONFIG_SYS_CPU, CONFIG_SYS_BOARD, respectively.
> > 
> > We are discussing the introduction of Kconfig.
> > In our discussion, we found boolean CONFIG macros are more useful
> > in Kconfig context.
> > 
> > That is,
> > 
> > CONFIG_ARM=y
> > CONFIG_CPU_ARMv7=y
> > CONFIG_BOARD_HARMONY=y
> > CONFIG_VENDOR_NVIDIA=y
> > 
> > rather than
> > 
> > CONFIG_SYS_ARCH="arm"
> > CONFIG_SYS_CPU="armv7"
> > CONFIG_SYS_BOARD="harmony"
> > CONFIG_SYS_VENDOR="nvidia"
> 
> I understand your intention - but does this not mean that we lose all
> flexibility in assigning board and vendor names?  So far, we allow any
> kind of names, lowercase and uppercase and mixed.  Will we not lose
> this capability?  Also, we have '-' characters in a number of board
> names - would this not also cause trouble?
> 
> Finally, I don't see what your replacement code would be to create the
> set of environment settigns - and I think these are needed, as some
> user defined scripts are processing these?

The user who needs such environment setting can
add them by using CONFIG_EXTRA_ENV_SETTINGS.

For example,

#define CONFIG_EXTRA_ENV_SETTINGS \
   "arch=arm\0" \
   "cpu=armv7\0" \
   "soc=tegra20\0"

I am not sure this is acceptable.



Best Regards
Masahiro Yamada

  reply	other threads:[~2014-04-23 12:03 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-22  9:43 [U-Boot] [RFC PATCH 0/3] Remove CONFIG_SYS_{ARCH, CPU, SOC, VENDOR, BOARD} Masahiro Yamada
2014-04-22  9:43 ` [U-Boot] [RFC PATCH 1/3] env: drop CONFIG_ENV_VARS_UBOOT_CONFIG support Masahiro Yamada
2014-04-22 12:13   ` Wolfgang Denk
2014-04-23 12:03     ` Masahiro Yamada [this message]
2014-04-23 16:08       ` Stephen Warren
2014-04-24  1:39         ` Masahiro Yamada
2014-04-23 19:13       ` Wolfgang Denk
2014-04-24  1:19         ` Masahiro Yamada
2014-04-22  9:43 ` [U-Boot] [RFC PATCH 2/3] cmd_pxe: remove SoC, ARCH path from pxe_default_path Masahiro Yamada
2014-04-22 12:55   ` Rob Herring
2014-04-22 15:40   ` Stephen Warren
2014-04-22  9:43 ` [U-Boot] [RFC PATCH 3/3] mkconfig: Do not define CONFIG_SYS_{ARCH, CPU, SOC, VENDOR, BOARD} in config.h Masahiro Yamada
2014-04-22 15:42   ` Stephen Warren
2014-04-23  7:33   ` Lukasz Majewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140423210335.18EE.AA925319@jp.panasonic.com \
    --to=yamada.m@jp.panasonic.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox