* [U-Boot] [PATCH] dfu:fix: Replace wrong return value with proper one
@ 2014-04-24 8:24 Lukasz Majewski
2014-04-24 18:50 ` Marek Vasut
0 siblings, 1 reply; 2+ messages in thread
From: Lukasz Majewski @ 2014-04-24 8:24 UTC (permalink / raw)
To: u-boot
This patch remove always false (since we tested ret = 0) ternary operator
with ret value returned.
Signed-off-by: Lukasz Majewski <l.majewski@samsung.com>
---
drivers/dfu/dfu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/dfu/dfu.c b/drivers/dfu/dfu.c
index a41195b..422cdba 100644
--- a/drivers/dfu/dfu.c
+++ b/drivers/dfu/dfu.c
@@ -238,7 +238,7 @@ int dfu_write(struct dfu_entity *dfu, void *buf, int size, int blk_seq_num)
ret = tret;
}
- return ret = 0 ? size : ret;
+ return ret;
}
static int dfu_read_buffer_fill(struct dfu_entity *dfu, void *buf, int size)
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [U-Boot] [PATCH] dfu:fix: Replace wrong return value with proper one
2014-04-24 8:24 [U-Boot] [PATCH] dfu:fix: Replace wrong return value with proper one Lukasz Majewski
@ 2014-04-24 18:50 ` Marek Vasut
0 siblings, 0 replies; 2+ messages in thread
From: Marek Vasut @ 2014-04-24 18:50 UTC (permalink / raw)
To: u-boot
On Thursday, April 24, 2014 at 10:24:53 AM, Lukasz Majewski wrote:
> This patch remove always false (since we tested ret = 0) ternary operator
> with ret value returned.
>
> Signed-off-by: Lukasz Majewski <l.majewski@samsung.com>
> ---
> drivers/dfu/dfu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-04-24 18:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-24 8:24 [U-Boot] [PATCH] dfu:fix: Replace wrong return value with proper one Lukasz Majewski
2014-04-24 18:50 ` Marek Vasut
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox