From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Sat, 26 Apr 2014 20:31:52 +0200 Subject: [U-Boot] [PATCH v3 1/9] sunxi: add sun7i clocks and timer support. In-Reply-To: <1397844350-7341-1-git-send-email-ijc@hellion.org.uk> References: <1397844323.19277.26.camel@hastur.hellion.org.uk> <1397844350-7341-1-git-send-email-ijc@hellion.org.uk> Message-ID: <201404262031.52152.marex@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Friday, April 18, 2014 at 08:05:42 PM, Ian Campbell wrote: [...] > +static ulong read_timer(void) > +{ > + struct sunxi_timer_reg *timers = > + (struct sunxi_timer_reg *)SUNXI_TIMER_BASE; > + struct sunxi_timer *timer = &timers->timer[TIMER_NUM]; > + /* The hardware timer counts down, therefore we invert to > + * produce an incrementing timer. */ This comment doesn't follow coding style. > + return ~readl(&timer->val); > +} [...] Best regards, Marek Vasut