[U-Boot] [PATCH v3 6/9] sunxi: add gmac Ethernet support

Ian Campbell
2014-04-27T16:33:52Z

On Sat, 2014-04-26 at 20:41 +0200, Marek Vasut wrote:
> > +#define CONFIG_CMD_SNTP
>
> Do you really need this ?

Doubtful, sunxi doesn't enable (or support) CONFIG_CMD_DATE so SNTP
doesn't even do anything. I'll drop it.

> > +#define CONFIG_TIMESTAMP /* Needed by SNTP */
> > +#define CONFIG_CMD_DNS
> > +#define CONFIG_NETCONSOLE
> > +#define CONFIG_BOOTP_NISDOMAIN
> > +#define CONFIG_BOOTP_BOOTFILESIZE
> > +#define CONFIG_BOOTP_DNS2
> > +#define CONFIG_BOOTP_SEND_HOSTNAME
> > +#define CONFIG_BOOTP_NTPSERVER
> > +#define CONFIG_BOOTP_TIMEOFFSET
> > +#define CONFIG_BOOTP_MAY_FAIL
> > +#define CONFIG_BOOTP_SERVERIP
> > +#define CONFIG_BOOTP_DHCP_REQUEST_DELAY 50000
>
> Just delete this BOOTP nonsense.

All of them? I'm thinking of keeping SEND_HOSTNAME which seems useful
(surprised it isn't in config_distro_defaults.h) and perhaps DNS2 (I
figure why not?).

The only other one I'm not sure about is BOOTFILESIZE -- it's widely
enabled but AFAICT is only logged and does nothing useful. I'm erring on
the side of dropping it.

Ian.