From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lukasz Majewski Date: Wed, 30 Apr 2014 10:35:52 +0200 Subject: [U-Boot] [PATCH v5 01/12] mmc: mmc header fix In-Reply-To: <1398712412-15503-2-git-send-email-m.zalega@samsung.com> References: <1389277919-15279-1-git-send-email-m.zalega@samsung.com> <1398712412-15503-1-git-send-email-m.zalega@samsung.com> <1398712412-15503-2-git-send-email-m.zalega@samsung.com> Message-ID: <20140430103552.2836ed02@amdc2363> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Pantelis, > Structure definition used type block_dev_desc_t, defined in part.h, > which wasn't included in mmc.h. It worked only in circumstances when > common.h, or another header using part.h was incuded in > implementation files. > > Signed-off-by: Mateusz Zalega > Cc: Minkyu Kang > Cc: Pantelis Antoniou > --- > Changes since v1: > - none > --- > include/mmc.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/mmc.h b/include/mmc.h > index 42d0125..bc11f45 100644 > --- a/include/mmc.h > +++ b/include/mmc.h > @@ -12,6 +12,7 @@ > > #include > #include > +#include > > #define SD_VERSION_SD 0x20000 > #define SD_VERSION_3 (SD_VERSION_SD | 0x300) I've agreed with Marek Vasut about those patches. I will take them to u-boot-dfu tree and send PR to Marek. Since this is a cleanup patch (not connected to DFU/USB) I would like to take it to the u-boot-dfu to prevent it from being vanished on the ML. Pantelis, could you ACK this patch? And then I will add it to u-boot-dfu. -- Best regards, Lukasz Majewski Samsung R&D Institute Poland (SRPOL) | Linux Platform Group