From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marex@denx.de>
Date: Thu, 1 May 2014 21:23:29 +0200
Subject: [U-Boot] [PATCH 3/2] net/designware: reorder struct dw_eth_dev
	to pack more efficiently.
In-Reply-To: <1398970918.19277.181.camel@hastur.hellion.org.uk>
References: <1398714651-1175-2-git-send-email-ijc@hellion.org.uk>
	<1398970918.19277.181.camel@hastur.hellion.org.uk>
Message-ID: <201405012123.29978.marex@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Thursday, May 01, 2014 at 09:01:58 PM, Ian Campbell wrote:
> The {tx,rx}_mac_descrtable fields are aligned to ARCH_DMA_MINALIGN, which
> could be 256 or even larger. That means there is a potentially huge hole
> in the struct before those fields, so move them to the front where they
> are better packed.
> 
> Moving them to the front also helps ensure that so long as dw_eth_dev is
> properly aligned (which it is since "net/designware: ensure device private
> data is DMA aligned.") the {tx,rx}_mac_descrtable will be too, or at least
> avoids having to worry too much about compiler specifics.
> 
> Signed-off-by: Ian Campbell <ijc@hellion.org.uk>
> Cc: Alexey Brodkin <abrodkin@synopsys.com>

Acked-by: Marek Vasut <marex@denx.de>

Best regards,
Marek Vasut