From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Fri, 2 May 2014 06:45:15 +0200 Subject: [U-Boot] [PATCH 7/8] ums: move all variable declarations to the start of the block In-Reply-To: <53627D4A.6000401@wwwdotorg.org> References: <1398892402-9816-1-git-send-email-swarren@wwwdotorg.org> <201405011251.25998.marex@denx.de> <53627D4A.6000401@wwwdotorg.org> Message-ID: <201405020645.15539.marex@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Thursday, May 01, 2014 at 06:58:50 PM, Stephen Warren wrote: > On 05/01/2014 04:51 AM, Marek Vasut wrote: > > On Wednesday, April 30, 2014 at 11:13:21 PM, Stephen Warren wrote: > >> From: Stephen Warren > >> > >> It's easier to assign values to the variables inside an if statement > >> body if the assignment and declaration are separate. > >> > >> Cc: Przemyslaw Marczak > >> Cc: Lukasz Majewski > >> Signed-off-by: Stephen Warren > >> --- > >> > >> common/cmd_usb_mass_storage.c | 24 ++++++++++++++++-------- > >> 1 file changed, 16 insertions(+), 8 deletions(-) > > > > This doesn't apply on u-boot-usb/master, sorry. > > Is this the first patch in the series which doesn't apply? Did you apply > any of the earlier patches? I guess I'll go try to rebase the series and > find out myself... 7/8 doesn't apply . > This is why we need a "uboot-next" just like linux-next, and stricter > controls on which git repos take patches that touch subsystem code, to > avoid cross-repo conflicts:-( Yep, u-boot-next would be nice and so would be u-boot-stable . Volunteers welcome ;-) Best regards, Marek Vasut