public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] U-Boot, dm, ubi: struct device is declared twice
Date: Fri, 2 May 2014 08:06:39 +0200	[thread overview]
Message-ID: <201405020806.39415.marex@denx.de> (raw)
In-Reply-To: <53632AC5.1030702@denx.de>

On Friday, May 02, 2014 at 07:19:01 AM, Heiko Schocher wrote:
> Hello Simon, Marek,
> 
> just updating to current mainline code and defining
> CONFIG_SYS_GENERIC_BOARD pops up the following error:
> 
>   CC      common/board_r.o
> In file included from include/linux/mtd/flashchip.h:21:0,
>                   from include/linux/mtd/nand.h:31,
>                   from include/nand.h:39,
>                   from common/board_r.c:40:
> include/ubi_uboot.h:202:8: error: redefinition of 'struct device'
>   struct device {
>          ^
> In file included from include/dm.h:10:0,
>                   from common/board_r.c:21:
> include/dm/device.h:56:8: note: originally defined here
>   struct device {
>          ^
> make[1]: *** [common/board_r.o] Fehler 1
> make: *** [common] Fehler 2
> pollux:u-boot hs [20140502] $
> 
> for a not yet mainlined imx6 board using UBI/UBIFS on nand. I am
> currently sync current Linux MTD/UBI and UBIFS code to U-Boot, but
> I think this error should pop up for all boards using DM and UBI ...

In the ideal case, we should use the same struct device for both UBI and DM, but 
we cannot do that. Thus, renaming the DM struct device would be the best option 
for now.

btw. are you syncing the UBI/UBIFS code from mainline into U-Boot now ? Can you 
keep me posted on patches please ?

Best regards,
Marek Vasut

  parent reply	other threads:[~2014-05-02  6:06 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-02  5:19 [U-Boot] U-Boot, dm, ubi: struct device is declared twice Heiko Schocher
2014-05-02  5:48 ` Wolfgang Denk
2014-05-02  6:06 ` Marek Vasut [this message]
2014-05-02  7:16   ` Heiko Schocher
2014-05-02 14:29     ` Simon Glass
2014-05-05  5:55       ` Heiko Schocher
2014-05-05 17:17         ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201405020806.39415.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox