From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lukasz Majewski Date: Mon, 05 May 2014 09:50:02 +0200 Subject: [U-Boot] [PATCH v5 03/12] usb: dfu: fix boards wo USB cable detection In-Reply-To: <1398712412-15503-4-git-send-email-m.zalega@samsung.com> References: <1389277919-15279-1-git-send-email-m.zalega@samsung.com> <1398712412-15503-1-git-send-email-m.zalega@samsung.com> <1398712412-15503-4-git-send-email-m.zalega@samsung.com> Message-ID: <20140505095002.39d96ad8@amdc2363> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Mateusz, > Former usb_cable_connected() patch broke compilation of boards which > do not support this feature. > > I've renamed usb_cable_connected() to g_dnl_usb_cable_connected() and > added its default implementation to gadget downloader driver code. > There's only one driver of this kind and it's unlikely there'll be > another, so there's no point in keeping it in /common. > > Previously this function was declared in usb.h. I've moved it, since > it's more appropriate to keep it in g_dnl.h - usb.h seems to be > intended for USB host implementation. > > Existing code, confronted with default -EOPNOTSUPP return value, > continues as if the cable was connected. > > CONFIG_USB_CABLE_CHECK was removed. > > Signed-off-by: Mateusz Zalega > Cc: Lukasz Majewski > Cc: Marek Vasut Applied to u-boot-dfu. Thanks -- Best regards, Lukasz Majewski Samsung R&D Institute Poland (SRPOL) | Linux Platform Group