public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] at91: video: atmel_hlcdfb.c: fix bad timing configuration
@ 2014-03-10  8:40 Josh Wu
  2014-05-05  9:51 ` Anatolij Gustschin
  0 siblings, 1 reply; 2+ messages in thread
From: Josh Wu @ 2014-03-10  8:40 UTC (permalink / raw)
  To: u-boot

The right correspondance between LCD margins and LCD timings is:
    * upper margin -> vertical back porch
    * lower margin -> vertical front porch
    * left  margin -> horizontal back porch
    * right margin -> horizontal front porch

Signed-off-by: Josh Wu <josh.wu@atmel.com>
---
 drivers/video/atmel_hlcdfb.c |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/video/atmel_hlcdfb.c b/drivers/video/atmel_hlcdfb.c
index fc95897..e5d287d 100644
--- a/drivers/video/atmel_hlcdfb.c
+++ b/drivers/video/atmel_hlcdfb.c
@@ -144,12 +144,12 @@ void lcd_ctrl_init(void *lcdbase)
 	value |= LCDC_LCDCFG1_HSPW(panel_info.vl_hsync_len - 1);
 	lcdc_writel(&regs->lcdc_lcdcfg1, value);
 
-	value = LCDC_LCDCFG2_VBPW(panel_info.vl_lower_margin);
-	value |= LCDC_LCDCFG2_VFPW(panel_info.vl_upper_margin - 1);
+	value = LCDC_LCDCFG2_VBPW(panel_info.vl_upper_margin);
+	value |= LCDC_LCDCFG2_VFPW(panel_info.vl_lower_margin - 1);
 	lcdc_writel(&regs->lcdc_lcdcfg2, value);
 
-	value = LCDC_LCDCFG3_HBPW(panel_info.vl_right_margin - 1);
-	value |= LCDC_LCDCFG3_HFPW(panel_info.vl_left_margin - 1);
+	value = LCDC_LCDCFG3_HBPW(panel_info.vl_left_margin - 1);
+	value |= LCDC_LCDCFG3_HFPW(panel_info.vl_right_margin - 1);
 	lcdc_writel(&regs->lcdc_lcdcfg3, value);
 
 	/* Display size */
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 2+ messages in thread
* [U-Boot] [PATCH] at91: video: atmel_hlcdfb.c: fix bad timing configuration
  2014-03-10  8:40 [U-Boot] [PATCH] at91: video: atmel_hlcdfb.c: fix bad timing configuration Josh Wu
@ 2014-05-05  9:51 ` Anatolij Gustschin
  0 siblings, 0 replies; 2+ messages in thread
From: Anatolij Gustschin @ 2014-05-05  9:51 UTC (permalink / raw)
  To: u-boot

On Mon, 10 Mar 2014 16:40:41 +0800
Josh Wu <josh.wu@atmel.com> wrote:

> The right correspondance between LCD margins and LCD timings is:
>     * upper margin -> vertical back porch
>     * lower margin -> vertical front porch
>     * left  margin -> horizontal back porch
>     * right margin -> horizontal front porch
> 
> Signed-off-by: Josh Wu <josh.wu@atmel.com>
> ---
>  drivers/video/atmel_hlcdfb.c |    8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)

applied to u-boot-video/master. Thanks!

Anatolij

^ permalink raw reply	[flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-05-05  9:51 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-03-10  8:40 [U-Boot] [PATCH] at91: video: atmel_hlcdfb.c: fix bad timing configuration Josh Wu
2014-05-05  9:51 ` Anatolij Gustschin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox