From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lukasz Majewski Date: Mon, 5 May 2014 23:10:43 +0200 Subject: [U-Boot] [PATCH 1/2] fs:ext4:cleanup: Remove superfluous code In-Reply-To: References: <1398854380-10778-1-git-send-email-l.majewski@samsung.com> <1398854380-10778-2-git-send-email-l.majewski@samsung.com> <20140505072055.4664a0e8@amdc2363> Message-ID: <20140505231043.4100d112@jawa> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Mon, 5 May 2014 08:24:22 -0600 Simon Glass wrote: > > Hi Lukasz, > > On 4 May 2014 23:20, Lukasz Majewski wrote: > > Hi Simon, > > > >> On 30 April 2014 03:39, Lukasz Majewski > >> wrote: > >> > Code responsible for handling situation when ext4 has block size > >> > of 1024B can be ordered to take less space. > >> > > >> > This patch does that for ext4 common and write files. > >> > > >> > Signed-off-by: Lukasz Majewski > >> > >> Reviewed-by: Simon Glass > >> > >> > --- > >> > fs/ext4/ext4_common.c | 6 ++---- > >> > fs/ext4/ext4_write.c | 50 > >> > ++++++++++++++++--------------------------------- 2 files > >> > changed, 18 insertions(+), 38 deletions(-) > >> > > >> > diff --git a/fs/ext4/ext4_common.c b/fs/ext4/ext4_common.c > >> > index 02da75c..62e2e80 100644 > >> > --- a/fs/ext4/ext4_common.c > >> > +++ b/fs/ext4/ext4_common.c > >> [snip] > >> > >> > @@ -181,10 +179,8 @@ static void > >> > delete_double_indirect_block(struct ext2_inode *inode) break; > >> > > >> > debug("DICB releasing %u\n", *di_buffer); > >> > - if (fs->blksz != 1024) { > >> > - bg_idx = (*di_buffer) / > >> > blk_per_grp; > >> > - } else { > >> > - bg_idx = (*di_buffer) / > >> > blk_per_grp; > >> > + bg_idx = (*di_buffer) / blk_per_grp; > >> > >> You don't need the brackets here (or below). > > > > Maybe the GIT formatting is a bit misleading, but I've double > > checked and it seems that those parenthesis are necessary here. > > OK. What is di_buffer such that (*di_buffer) works but *di_buffer > doesn't? It is hard to admit :-), but I've misunderstood you. I thought that you are talking about the {} parentheses. I will check the code tomorrow and prepare proper patch. > > Regards, > Simon Best regards, Lukasz Majewski -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 198 bytes Desc: not available URL: