[U-Boot] [PATCH] omap4: duovero: Add Gumstix DuoVero machine.

[Tom Rini <trini@ti.com>]

On Tue, Apr 29, 2014 at 02:31:33PM -0700, Ash Charles wrote:

> This adds the Gumstix DuoVero machine [1].  This is a OMAP4430-based
> computer-on-module (COM aka SOM) that can be mounted on various
> expansion boards with different peripherals.
[snip]
> +	gd->bd->bi_arch_number = MACH_TYPE_OMAP4_DUOVERO;

You don't really support non-DT kernels do you?

> +	gd->bd->bi_boot_params = (0x80000000 + 0x100); /* boot param addr */

CONFIG_SYS_SDRAM_BASE + ...

> diff --git a/include/configs/ti_omap4_common.h b/include/configs/ti_omap4_common.h
> index bcb5eab..4563cbb 100644
> --- a/include/configs/ti_omap4_common.h
> +++ b/include/configs/ti_omap4_common.h
> @@ -111,9 +111,13 @@
>  	"importbootenv=echo Importing environment from mmc${mmcdev} ...; " \
>  		"env import -t ${loadaddr} ${filesize}\0" \
>  	"loadimage=load mmc ${bootpart} ${loadaddr} ${bootdir}/${bootfile}\0" \
> +	"loaduimage=fatload mmc ${mmcdev} ${loadaddr} uImage\0" \
>  	"mmcboot=echo Booting from mmc${mmcdev} ...; " \
>  		"run mmcargs; " \
>  		"bootz ${loadaddr} - ${fdtaddr}\0" \
> +	"uimageboot=echo Booting from mmc${mmcdev} ...; " \
> +		"run mmcargs; " \
> +		"bootm ${loadaddr}\0" \

First, please use 'load' not 'fatload' and second..

>  	"findfdt="\
>  		"if test $board_name = sdp4430; then " \
>  			"setenv fdtfile omap4-sdp.dtb; fi; " \
> @@ -123,6 +127,8 @@
>  			"setenv fdtfile omap4-panda-a4.dtb; fi;" \
>  		"if test $board_name = panda-es; then " \
>  			"setenv fdtfile omap4-panda-es.dtb; fi;" \
> +		"if test $board_name = duovero; then " \
> +			"setenv fdtfile omap4-duovero.dtb; fi;" \
>  		"if test $fdtfile = undefined; then " \
>  			"echo WARNING: Could not determine device tree to use; fi; \0" \
>  	"loadfdt=load mmc ${bootpart} ${fdtaddr} ${bootdir}/${fdtfile}\0" \
> @@ -146,6 +152,9 @@
>  			"run loadfdt;" \
>  			"run mmcboot; " \
>  		"fi; " \
> +		"if run loaduimage; then " \
> +			"run uimageboot;" \
> +		"fi; " \

You really are using uImage and not zImage for this board, but not for
pepper?

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140506/76aa1ff2/attachment.pgp>