From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] usb: ci_udc: allow multiple buffer allocs per ep
Date: Wed, 7 May 2014 23:31:00 +0200 [thread overview]
Message-ID: <201405072331.01014.marex@denx.de> (raw)
In-Reply-To: <1399333692-1847-1-git-send-email-swarren@wwwdotorg.org>
On Tuesday, May 06, 2014 at 01:48:11 AM, Stephen Warren wrote:
> From: Stephen Warren <swarren@nvidia.com>
>
> Modify ci_ep_alloc_request() to return a dynamically allocated request
> object, rather than a singleton that's part of the endpoint. This
> requires moving various state from the endpoint structure to the request
> structure, since we need one copy per request.
>
> The "fast bounce buffer" b_fast is removed by this change rather than
> moved to the request object. Instead, we enhance the bounce buffer logic
> in ci_bounce()/ci_debounce() to keep the bounce buffer around between
> request submissions. This avoids the need to allocate an arbitrarily-
> sized bounce buffer up-front, yet avoids incurring the allocation
> overhead each time a request is submitted.
>
> A future enhancement would be to actually submit multiple requests to HW
> at once. The Linux driver shows that this is possible. That might improve
> throughput (depending on the USB protocol in use), since USB could be
> performing a transfer to one HW buffer in parallel with whatever SW
> actions U-Boot performs on another buffer. However, I have not made this
> change as part of this patch, in order to keep SW changes related to
> buffer management separate from any change in the way the HW is
> programmed.
Applied, thanks
Best regards,
Marek Vasut
next prev parent reply other threads:[~2014-05-07 21:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-05 23:48 [U-Boot] [PATCH 1/2] usb: ci_udc: allow multiple buffer allocs per ep Stephen Warren
2014-05-05 23:48 ` [U-Boot] [PATCH 2/2] usb: ums: remove ci_udc special case Stephen Warren
2014-05-07 21:31 ` Marek Vasut
2014-05-07 21:31 ` Marek Vasut [this message]
2014-06-02 22:57 ` [U-Boot] [PATCH 1/2] usb: ci_udc: allow multiple buffer allocs per ep Jörg Krause
2014-06-02 23:02 ` Jörg Krause
2014-06-10 19:34 ` Stephen Warren
2014-06-12 8:36 ` Jörg Krause
2014-06-12 12:59 ` Marek Vasut
2014-06-12 15:55 ` Stephen Warren
2014-06-12 17:30 ` Marek Vasut
2014-06-12 17:42 ` Stephen Warren
2014-06-16 1:00 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201405072331.01014.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox