From: Lukasz Majewski <l.majewski@samsung.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v4 1/3] usb:gadget:f_thor: code cleanup in function download_tail()
Date: Fri, 09 May 2014 10:35:54 +0200 [thread overview]
Message-ID: <20140509103554.76c6a050@amdc2363> (raw)
In-Reply-To: <536C820B.9080006@samsung.com>
Hi Przemyslaw, Marek,
> Hello Marek,
>
> On 04/28/2014 06:57 PM, Przemyslaw Marczak wrote:
> > In thor's download_tail() function, dfu_get_entity() is called
> > before each dfu_write() call and the returned entity pointers
> > are the same. So dfu_get_entity() can be called just once and
> > this patch changes this.
> >
> > Signed-off-by: Przemyslaw Marczak <p.marczak@samsung.com>
> > Cc: Lukasz Majewski <l.majewski@samsung.com>
> > Cc: Marek Vasut <marex@denx.de>
> > Cc: Heiko Schocher <hs@denx.de>
> > Cc: Tom Rini <trini@ti.com>
> >
> > ---
> > Changes v2:
> > - separate fix and cleanup into two commits
> >
> > Changes v3:
> > - download_tail(): add exit label
> >
> > Changes v4:
> > - none
>
> I've checked the u-boot-usb/master tree and I found that one commit
> of this patch set is missed, because it is v3 (there was only two
> commits). Could you please apply the patch set version 4?
I've discussed this issue with Przemek, and we agreed that Przemek will
prepare diff patch between version 3, which is already in mainline and
version 4.
Then, after ML review, I will pull them to u-boot-dfu branch.
Marek, does it work for you?
>
> Thank you,
--
Best regards,
Lukasz Majewski
Samsung R&D Institute Poland (SRPOL) | Linux Platform Group
next prev parent reply other threads:[~2014-05-09 8:35 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-17 17:31 [U-Boot] [PATCH] usb:gadget:f_thor: fix write to filesystem by add dfu_flush() Przemyslaw Marczak
2014-04-17 18:11 ` Marek Vasut
2014-04-18 7:48 ` [U-Boot] [PATCH v2 1/2] usb:gadget:f_thor: code cleanup in function download_tail() Przemyslaw Marczak
2014-04-18 7:48 ` [U-Boot] [PATCH v2 2/2] usb:gadget:f_thor: fix write to filesystem by add dfu_flush() Przemyslaw Marczak
2014-04-21 15:08 ` Marek Vasut
2014-04-21 15:08 ` [U-Boot] [PATCH v2 1/2] usb:gadget:f_thor: code cleanup in function download_tail() Marek Vasut
2014-04-23 9:43 ` [U-Boot] [PATCH v3 " Przemyslaw Marczak
2014-04-23 9:43 ` [U-Boot] [PATCH v3 2/2] usb:gadget:f_thor: fix write to filesystem by add dfu_flush() Przemyslaw Marczak
2014-04-23 12:40 ` Lukasz Majewski
2014-04-23 12:46 ` Marek Vasut
2014-04-28 16:57 ` [U-Boot] [PATCH v4 1/3] usb:gadget:f_thor: code cleanup in function download_tail() Przemyslaw Marczak
2014-04-28 16:57 ` [U-Boot] [PATCH v4 2/3] usb:gadget:f_thor: fix write to filesystem by add dfu_flush() Przemyslaw Marczak
2014-04-28 16:57 ` [U-Boot] [PATCH v4 3/3] drivers:dfu: dfu_flush(): add raw data flush to complete Przemyslaw Marczak
2014-05-06 6:30 ` [U-Boot] [PATCH v4 1/3] usb:gadget:f_thor: code cleanup in function download_tail() Przemyslaw Marczak
2014-05-09 7:21 ` Przemyslaw Marczak
2014-05-09 8:35 ` Lukasz Majewski [this message]
2014-05-10 9:41 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140509103554.76c6a050@amdc2363 \
--to=l.majewski@samsung.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox