public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] zynq: add empty xil_io.h to avoid compile error
Date: Fri, 9 May 2014 11:05:50 -0400	[thread overview]
Message-ID: <20140509150550.GH22182@bill-the-cat> (raw)
In-Reply-To: <536B4065.7000907@monstr.eu>

On Thu, May 08, 2014 at 10:29:25AM +0200, Michal Simek wrote:
> On 05/08/2014 10:13 AM, Masahiro Yamada wrote:
> > ps7_init.c exported by hw project has #include "xil_io.h" line
> > but U-Boot does not have "xil_io.h".
> > 
> > So we get an error on SPL build:
> >   ps7_init.c:12581:20: fatal error: xil_io.h: No such file or directory
> > 
> > We can delete the include directive in ps7_init.c to avoid this error.
> > But it is painful to do this every time we export ps7_init.c file.
> > 
> > Instead, we can put an empty xil_io.h in the same directory
> > so we can directly copy ps7_init.c as is.
> > 
> > Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
> > Cc: Michal Simek <michal.simek@xilinx.com>
> > ---
> >  board/xilinx/zynq/xil_io.h | 13 +++++++++++++
> >  1 file changed, 13 insertions(+)
> >  create mode 100644 board/xilinx/zynq/xil_io.h
> > 
> > diff --git a/board/xilinx/zynq/xil_io.h b/board/xilinx/zynq/xil_io.h
> > new file mode 100644
> > index 0000000..e59a977
> > --- /dev/null
> > +++ b/board/xilinx/zynq/xil_io.h
> > @@ -0,0 +1,13 @@
> > +/*
> > + * SPDX-License-Identifier:    GPL-2.0+
> > + */
> > +
> > +#ifndef XIL_IO_H           /* prevent circular inclusions */
> > +#define XIL_IO_H
> > +
> > +/*
> > + * This empty file is here because ps7_init.c exported by hw project
> > + * has #include "xil_io.h" line.
> > + */
> > +
> > +#endif /* XIL_IO_H */
> > 
> 
> This is good if this is acceptable by others.
> 
> Acked-by: Michal Simek <monstr@monstr.eu>

I can live with this too.

Acked-by: Tom Rini <trini@ti.com>

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140509/43b96ae3/attachment.pgp>

      reply	other threads:[~2014-05-09 15:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-08  8:13 [U-Boot] [PATCH] zynq: add empty xil_io.h to avoid compile error Masahiro Yamada
2014-05-08  8:29 ` Michal Simek
2014-05-09 15:05   ` Tom Rini [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140509150550.GH22182@bill-the-cat \
    --to=trini@ti.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox