[U-Boot] Building under Cygwin - "-ansi" flag?

[Tom Rini <trini@ti.com>]

On Thu, May 08, 2014 at 02:49:35PM +0300, Vasili Galka wrote:
> Hi,
> 
> I'm building u-boot (am335x_evm config) using arm-none-eabi toolchain
> under Cygwin. When trying to build unmodified v2014.04 tag I get some
> errors. However, if I remove the "-ansi" flag from the Makefile,
> everything builds fine:
> 
> -ifeq ($(HOSTOS),cygwin)
> -HOSTCFLAGS    += -ansi
> -endif
> 
> I tried tracking down where those lines came from and why building
> under Cygwin requires separate treatment. I found our this originates
> from the following commit (dated Jan 2008):
> 
>   SHA-1: 883e3925d99a8dd69c5b0201cba5b1887f88f95c
> 
>   * Fix build problems under Cygwin
> 
>   This patch allows u-boot to build without error in a cygwin
>   environment.  Cygwin does not define __u64 in it's
>   include/asm/types.h file.  The -idirafter flag in the u-boot
>   build causes the inclusion of the cygwin types.h file as opposed
>   to u-bot/include/asm/types.h file which does define __u64.
>   Subsequently, sha1.c compile fails due to unknown symbol.
> 
>   Signed-off-by: Brian Miller <raptorbrino@netscape.net>
> 
> This comment does not really explain why "-ansi" flag is required.

-ansi changes include order perhaps?

> Personally, I don't see any reason for it.
> 
> Maybe it should be removed at all?

Yes, but can you please test a few more builds?  If you're able to use
MAKEALL, please run MAKEALL -a arm

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140509/2ba29205/attachment.pgp>