public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] env_eeprom: Assign default environment during board_init_f
Date: Fri, 9 May 2014 14:08:35 -0400	[thread overview]
Message-ID: <20140509180835.GU22182@bill-the-cat> (raw)
In-Reply-To: <9ce3bf15819bc6aef95f491a40225d08c91aa285.1398433742.git.michal.simek@xilinx.com>

On Fri, Apr 25, 2014 at 03:49:04PM +0200, Michal Simek wrote:

> From: Siva Durga Prasad Paladugu <siva.durga.paladugu@xilinx.com>
> 
> Assign default environment and set env valid during board_init_f
> before relocation as the actual environment will be read from
> eeprom later.
> 
> Signed-off-by: Siva Durga Prasad Paladugu <sivadur@xilinx.com>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
> 
>  common/env_eeprom.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/common/env_eeprom.c b/common/env_eeprom.c
> index 0db2bb6..a4020bc 100644
> --- a/common/env_eeprom.c
> +++ b/common/env_eeprom.c
> @@ -224,6 +224,7 @@ int env_init(void)
>  #else
>  int env_init(void)
>  {
> +#ifdef ENV_IS_EMBEDDED
>  	ulong crc, len, new;
>  	unsigned off;
>  	uchar buf[64];
> @@ -256,6 +257,10 @@ int env_init(void)
>  		gd->env_addr	= 0;
>  		gd->env_valid	= 0;
>  	}
> +#else
> +	gd->env_addr = (ulong)&default_environment[0];
> +	gd->env_valid = 1;
> +#endif
> 
>  	return 0;
>  }

Sorry for the delay.  This looks fine but doesn't correct the redundant
env case which has the same problem.  It would be nice if you had time
to first consolidate env_init for both cases (see how env_nand.c does
it) as well.  Thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140509/e3b1f253/attachment.pgp>

  parent reply	other threads:[~2014-05-09 18:08 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-25 13:49 [U-Boot] [PATCH] env_eeprom: Assign default environment during board_init_f Michal Simek
2014-05-06 12:20 ` Michal Simek
2014-05-09 18:08 ` Tom Rini [this message]
2014-05-13 13:10   ` Michal Simek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140509180835.GU22182@bill-the-cat \
    --to=trini@ti.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox