public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Siarhei Siamashka <siarhei.siamashka@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [linux-sunxi] [PATCH 3/2] net/designware: reorder struct dw_eth_dev to pack more efficiently.
Date: Wed, 14 May 2014 11:01:59 +0300	[thread overview]
Message-ID: <20140514110159.3e600217@i7> (raw)
In-Reply-To: <1400053970.27638.12.camel@dagon.hellion.org.uk>

On Wed, 14 May 2014 08:52:50 +0100
Ian Campbell <ijc@hellion.org.uk> wrote:

> On Wed, 2014-05-14 at 10:44 +0300, Siarhei Siamashka wrote:
> > > diff --git a/drivers/net/designware.h b/drivers/net/designware.h
> > > index 382b0c7..6d94b3a 100644
> > > --- a/drivers/net/designware.h
> > > +++ b/drivers/net/designware.h
> > > @@ -215,13 +215,13 @@ struct dmamacdescr {
> > >  #endif
> > >  
> > >  struct dw_eth_dev {
> > > +	struct dmamacdescr tx_mac_descrtable[CONFIG_TX_DESCR_NUM];
> > > +	struct dmamacdescr rx_mac_descrtable[CONFIG_RX_DESCR_NUM];
> > > +
> > >  	u32 interface;
> > >  	u32 tx_currdescnum;
> > >  	u32 rx_currdescnum;
> > >  
> > > -	struct dmamacdescr tx_mac_descrtable[CONFIG_TX_DESCR_NUM];
> > > -	struct dmamacdescr rx_mac_descrtable[CONFIG_RX_DESCR_NUM];
> > > -
> > >  	char txbuffs[TX_TOTAL_BUFSIZE];
> > >  	char rxbuffs[RX_TOTAL_BUFSIZE];
> > 
> > After this reordering, txbuffs and rxbuffs buffers become DMA unaligned.
> 
> Right, this is fixed in the repost which is part of "[PATCH v3 0/5]
> net/designware: fixes for data cache, phylib and burst size".

Oh, you just forgot to add the linux-sunxi list to CC when sending
the updated patches. This explains why I don't see them in my mailbox.

-- 
Best regards,
Siarhei Siamashka

  reply	other threads:[~2014-05-14  8:01 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-28 19:50 [U-Boot] [PATCH v2 2/2] net/designware: ensure cache invalidations are aligned to ARCH_DMA_MINALIGN Ian Campbell
2014-05-01 19:01 ` [U-Boot] [PATCH 3/2] net/designware: reorder struct dw_eth_dev to pack more efficiently Ian Campbell
2014-05-01 19:23   ` Marek Vasut
2014-05-14  7:44   ` [U-Boot] [linux-sunxi] " Siarhei Siamashka
2014-05-14  7:52     ` Ian Campbell
2014-05-14  8:01       ` Siarhei Siamashka [this message]
2014-05-14  8:32         ` Siarhei Siamashka
2014-05-14  9:25           ` Ian Campbell
2014-05-14  9:49         ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140514110159.3e600217@i7 \
    --to=siarhei.siamashka@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox