From: Luka Perkov <luka@openwrt.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] error when building env
Date: Mon, 19 May 2014 14:14:03 +0200 [thread overview]
Message-ID: <20140519121403.GA6376@w500.lan> (raw)
In-Reply-To: <20140516175805.GB7207@bill-the-cat>
Hi Tom,
On Fri, May 16, 2014 at 01:58:05PM -0400, Tom Rini wrote:
> On Fri, May 16, 2014 at 07:26:51PM +0200, Luka Perkov wrote:
> > when trying to build env with "-mfloat-abi=hard" I'm hitting this error:
> >
> > /opt/openwrt/trunk/staging_dir/toolchain-arm_cortex-a9+neon_gcc-4.8-linaro_uClibc-0.9.33.2_eabi/bin/arm-openwrt-linux-uclibcgnueabi-gcc -o tools/env/fw_printenv_unstripped tools/env/fw_env.o tools/env/fw_env_main.o tools/env/crc32.o tools/env/ctype.o tools/env/linux_string.o tools/env/env_attr.o tools/env/env_flags.o tools/env/aes.o
> > /opt/build/owrt_staging_dir/toolchain-arm_cortex-a9+neon_gcc-4.8-linaro_uClibc-0.9.33.2_eabi/bin/../lib/gcc/arm-openwrt-linux-uclibcgnueabi/4.8.3/../../../../arm-openwrt-linux-uclibcgnueabi/bin/ld: error: tools/env/fw_printenv_unstripped uses VFP register arguments, tools/env/fw_env.o does not
>
> Odd. I can build 'tools-only' with my hard float toolchain fine. Can
> you build with V=1 and see what files are perhaps not getting passed in
> a -mfloat option?
The patch below fixes the problem I was having. Is that good enough for
proper patch submission?
With it I am able to use replace default HOSTCFLAGS with what was
defined in TARGET_CFLAGS.
Luka
diff --git a/tools/env/Makefile b/tools/env/Makefile
index f5368bc..4de1d51 100644
--- a/tools/env/Makefile
+++ b/tools/env/Makefile
@@ -10,6 +10,10 @@
# with "CC" here for the maximum code reuse of scripts/Makefile.host.
HOSTCC = $(CC)
+ifneq ($(TARGET_CFLAGS),)
+HOSTCFLAGS = $(TARGET_CFLAGS)
+endif
+
# Compile for a hosted environment on the target
HOST_EXTRACFLAGS = $(patsubst -I%,-idirafter%, $(UBOOTINCLUDE)) \
-idirafter $(srctree)/tools/env \
next prev parent reply other threads:[~2014-05-19 12:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-16 17:26 [U-Boot] error when building env Luka Perkov
2014-05-16 17:58 ` Tom Rini
2014-05-19 12:14 ` Luka Perkov [this message]
2014-06-05 18:25 ` Tom Rini
2014-06-05 18:42 ` Jeroen Hofstee
2014-06-09 13:39 ` Masahiro Yamada
2014-06-12 9:50 ` Luka Perkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140519121403.GA6376@w500.lan \
--to=luka@openwrt.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox