From mboxrd@z Thu Jan  1 00:00:00 1970
From: Lukasz Majewski <l.majewski@samsung.com>
Date: Thu, 22 May 2014 12:43:33 +0200
Subject: [U-Boot] [PATCH v2] mmc: postponed needless timer initialization
In-Reply-To: <1398795330-24319-1-git-send-email-m.zalega@samsung.com>
References: <1398791805-23744-2-git-send-email-m.zalega@samsung.com>
	<1398795330-24319-1-git-send-email-m.zalega@samsung.com>
Message-ID: <20140522124333.5d3a9a85@amdc2363>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Pantelis,

> mmc_init() doesn't call get_timer() anymore if MMC is already
> initialized.
> 
> Signed-off-by: Mateusz Zalega <m.zalega@samsung.com>
> Cc: Pantelis Antoniou <panto@antoniou-consulting.com>
> ---
> Detached from earlier "DFU, MMC, Gadget, Goni, misc." series because
> of lack of relevance to other patches.
> 
> v2:
> - deleted change-id line from commit message, sorry!
> ---
>  drivers/mmc/mmc.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/mmc/mmc.c b/drivers/mmc/mmc.c
> index 16051e5..c93dc24 100644
> --- a/drivers/mmc/mmc.c
> +++ b/drivers/mmc/mmc.c
> @@ -1310,15 +1310,18 @@ static int mmc_complete_init(struct mmc *mmc)
>  int mmc_init(struct mmc *mmc)
>  {
>  	int err = IN_PROGRESS;
> -	unsigned start = get_timer(0);
> +	unsigned start;
>  
>  	if (mmc->has_init)
>  		return 0;
> +
> +	start = get_timer(0);
> +
>  	if (!mmc->init_in_progress)
>  		err = mmc_start_init(mmc);
> -
>  	if (!err || err == IN_PROGRESS)
>  		err = mmc_complete_init(mmc);
> +
>  	debug("%s: %d, time %lu\n", __func__, err, get_timer(start));
>  	return err;
>  }

Would you find some time to review this patch?

-- 
Best regards,

Lukasz Majewski

Samsung R&D Institute Poland (SRPOL) | Linux Platform Group