public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RFC, PATCH v2 1/4] dm: rename device struct to udevice
Date: Thu, 22 May 2014 20:43:07 -0400	[thread overview]
Message-ID: <20140523004307.GQ1752@bill-the-cat> (raw)
In-Reply-To: <CAPnjgZ0doZaXtz2r8=koqfyNu5CtdxkdutSnK176PJCLP0ESmA@mail.gmail.com>

On Thu, May 22, 2014 at 10:34:33AM -1000, Simon Glass wrote:
> +Tom
> 
> Hi Heiko,
> 
> On 22 May 2014 00:43, Heiko Schocher <hs@denx.de> wrote:
> > using UBI and DM together leads in compiler error, as
> > both define a "struct device", so rename "struct device"
> > in include/dm/device.h to "struct udevice", as we use
> > linux code (MTD/UBI/UBIFS some USB code,...) and cannot
> > change the linux "struct device"
> >
> > Signed-off-by: Heiko Schocher <hs@denx.de>
> > Cc: Simon Glass <sjg@chromium.org>
> > Cc: Marek Vasut <marex@denx.de>
> 
> I'm not 100% comfortable with this but if we really want to avoid
> changing kernel code that moves into U-Boot it is either this or a
> '#define device ldevice' at the top of the linux code/in a header. I'm
> not sure which is preferable.
> 
> If Tom decides to apply this, I'd like to request that it be done
> soon, since it has wide impact on driver model code.
> 
> Acked-by: Simon Glass <sjg@chromium.org>

I like it, I'm going to grab it Monday and I'm going to kick out -rc2 on
Monday as well, which should be a semi-handy branching off point too
then.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140522/c3fb7d83/attachment.pgp>

  parent reply	other threads:[~2014-05-23  0:43 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-22 10:43 [U-Boot] [RFC, PATCH v2 0/4] mtd, ubi, ubifs: resync with Linux-3.14 Heiko Schocher
2014-05-22 10:43 ` [U-Boot] [RFC,PATCH v2 1/4] dm: rename device struct to udevice Heiko Schocher
2014-05-22 20:34   ` [U-Boot] [RFC, PATCH " Simon Glass
2014-05-22 21:22     ` Jon Loeliger
2014-05-23  0:43     ` Tom Rini [this message]
2014-05-23  0:50       ` Simon Glass
2014-05-23  3:56     ` Heiko Schocher
2014-05-23 22:36       ` Simon Glass
2014-05-27 14:22   ` Tom Rini
2014-05-22 10:43 ` [U-Boot] [RFC,PATCH v2 2/4] lib, rbtree: resync with Linux-3.14 Heiko Schocher
2014-05-24 10:30   ` [U-Boot] [RFC, PATCH " Marek Vasut
2014-05-26  5:32     ` Heiko Schocher
2014-05-26  7:05       ` Marek Vasut
2014-05-27 14:21         ` Tom Rini
2014-05-28  5:24           ` Heiko Schocher
2014-05-22 10:43 ` [U-Boot] [RFC, PATCH v2 3/4] lib, list_sort: add list_sort from linux 3.14 Heiko Schocher
2014-05-22 10:43 ` [U-Boot] [RFC, PATCH v2 4/4] mtd, ubi, ubifs: resync with Linux-3.14 Heiko Schocher
2014-06-02 21:06 ` [U-Boot] [RFC, PATCH v2 0/4] " Jörg Krause
2014-06-03  5:14   ` Heiko Schocher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140523004307.GQ1752@bill-the-cat \
    --to=trini@ti.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox