[U-Boot] [RFC PATCH 14/22] console: Remove vprintf() optimisation for sandbox

Simon Glass
2014-05-24T21:21:13Z

If the console is not present, we try to reduce overhead by stopping any
output in vprintf(), before it gets to putc(). This is dubious merit in
general, but in the case of sandbox it is incorrect, since we have a
fallback console which reports errors very early in U-Boot. If this is
defeated U-Boot can hang or exit with no indication of what is wrong.

Remove the optimisation for sandbox.

Signed-off-by: Simon Glass <sjg@chromium.org>
---

common/console.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/common/console.c b/common/console.c
index 11c102a..5576dfd 100644
--- a/common/console.c
+++ b/common/console.c
@@ -504,7 +504,7 @@ int vprintf(const char *fmt, va_list args)
uint i;
char printbuffer[CONFIG_SYS_PBSIZE];

-#ifndef CONFIG_PRE_CONSOLE_BUFFER
+#if defined(CONFIG_PRE_CONSOLE_BUFFER) && !defined(CONFIG_SANDBOX)
if (!gd->have_console)
return 0;
#endif
--
1.9.1.423.g4596e3a