[U-Boot] [RFC PATCH 09/22] Remove form-feeds from dlmalloc.c

Jon Loeliger
2014-05-27T14:22:20Z

All in favor of the patch, but there is a typo here:

> These don't really server any purpose in the modern age, IMO. On the

s/server/serve/

Note trailing 'r'. IMO, I'd toss out the ', IMO' too if it were my patch.

Thanks,
jdl

On Sat, May 24, 2014 at 4:21 PM, Simon Glass <sjg@chromium.org> wrote:
> These don't really server any purpose in the modern age, IMO. On the
> other hand they show up as annoying control characters in my editor, which
> then happily removes them.
>
> I believe we can drop these characters from the file.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
>
> common/dlmalloc.c | 46 +++++++++++++++++++++++-----------------------
> 1 file changed, 23 insertions(+), 23 deletions(-)
>
> diff --git a/common/dlmalloc.c b/common/dlmalloc.c
> index 3c70d5d..d1cd561 100644
> --- a/common/dlmalloc.c
> +++ b/common/dlmalloc.c
> @@ -220,7 +220,7 @@
>
> */
>
> -
> +
>
> /* Preliminaries */
>
> @@ -1132,7 +1132,7 @@ gAllocatedSize))
>
> #endif
>
> -
> +
>
> /*
> Type declarations
> @@ -1272,7 +1272,7 @@ nextchunk-> +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
> serviced via calls to mmap, and then later released via munmap.
>
> */
> -
> +
> /* sizes, alignments */
>
> #define SIZE_SZ (sizeof(INTERNAL_SIZE_T))
> @@ -1297,7 +1297,7 @@ nextchunk-> +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
> #define aligned_OK(m) (((unsigned long)((m)) & (MALLOC_ALIGN_MASK)) == 0)
>
>
> -
> +
>
> /*
> Physical chunk operations
> @@ -1332,7 +1332,7 @@ nextchunk-> +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
> #define chunk_at_offset(p, s) ((mchunkptr)(((char*)(p)) + (s)))
>
>
> -
> +
>
> /*
> Dealing with use bits
> @@ -1371,7 +1371,7 @@ nextchunk-> +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
> (((mchunkptr)(((char*)(p)) + (s)))->size &= ~(PREV_INUSE))
>
>
> -
> +
>
> /*
> Dealing with size fields
> @@ -1394,7 +1394,7 @@ nextchunk-> +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
> #define set_foot(p, s) (((mchunkptr)((char*)(p) + (s)))->prev_size = (s))
>
>
> -
> +
>
>
> /*
> @@ -1566,7 +1566,7 @@ void mem_malloc_init(ulong start, ulong size)
>
> #define is_small_request(nb) (nb < MAX_SMALLBIN_SIZE - SMALLBIN_WIDTH)
>
> -
> +
>
> /*
> To help compensate for the large number of bins, a one-level index
> @@ -1590,7 +1590,7 @@ void mem_malloc_init(ulong start, ulong size)
> #define clear_binblock(ii) (binblocks_w = (mbinptr)(binblocks_r & ~(idx2binblock(ii))))
>
>
> -
> +
>
>
> /* Other static bookkeeping data */
> @@ -1628,7 +1628,7 @@ static unsigned int max_n_mmaps = 0;
> static unsigned long max_mmapped_mem = 0;
> #endif
>
> -
> +
>
> /*
> Debugging support
> @@ -1769,7 +1769,7 @@ static void do_check_malloced_chunk(p, s) mchunkptr p; INTERNAL_SIZE_T s;
> #define check_malloced_chunk(P,N)
> #endif
>
> -
> +
>
> /*
> Macro-based internal utilities
> @@ -1841,7 +1841,7 @@ static void do_check_malloced_chunk(p, s) mchunkptr p; INTERNAL_SIZE_T s;
> (last_remainder->fd = last_remainder->bk = last_remainder)
>
>
> -
> +
>
>
> /* Routines dealing with mmap(). */
> @@ -1972,7 +1972,7 @@ static mchunkptr mremap_chunk(p, new_size) mchunkptr p; size_t new_size;
> #endif /* HAVE_MMAP */
>
>
> -
> +
>
> /*
> Extend the top-most chunk by obtaining memory from system.
> @@ -2089,7 +2089,7 @@ static void malloc_extend_top(nb) INTERNAL_SIZE_T nb;
> }
>
>
> -
> +
>
> /* Main public routines */
>
> @@ -2396,7 +2396,7 @@ Void_t* mALLOc(bytes) size_t bytes;
> }
>
>
> -
> +
>
> /*
>
> @@ -2513,7 +2513,7 @@ void fREe(mem) Void_t* mem;
> }
>
>
> -
> +
>
>
> /*
> @@ -2750,7 +2750,7 @@ Void_t* rEALLOc(oldmem, bytes) Void_t* oldmem; size_t bytes;
> }
>
>
> -
> +
>
> /*
>
> @@ -2868,7 +2868,7 @@ Void_t* mEMALIGn(alignment, bytes) size_t alignment; size_t bytes;
>
> }
>
> -
> +
>
>
> /*
> @@ -2975,7 +2975,7 @@ void cfree(mem) Void_t *mem;
> }
> #endif
>
> -
> +
>
> /*
>
> @@ -3056,7 +3056,7 @@ int malloc_trim(pad) size_t pad;
> }
> }
>
> -
> +
>
> /*
> malloc_usable_size:
> @@ -3092,7 +3092,7 @@ size_t malloc_usable_size(mem) Void_t* mem;
> }
>
>
> -
> +
>
> /* Utility to update current_mallinfo for malloc_stats and mallinfo() */
>
> @@ -3136,7 +3136,7 @@ static void malloc_update_mallinfo()
> }
> #endif /* DEBUG */
>
> -
> +
>
> /*
>
> @@ -3183,7 +3183,7 @@ struct mallinfo mALLINFo()
> #endif /* DEBUG */
>
>
> -
> +
>
> /*
> mallopt:
> --
> 1.9.1.423.g4596e3a
>
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot