From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Tue, 3 Jun 2014 13:25:11 +0200 Subject: [U-Boot] [RFC PATCH 03/22] dm: Make sure that the root device is probed In-Reply-To: References: <1400966481-14131-1-git-send-email-sjg@chromium.org> <201406011933.49402.marex@denx.de> Message-ID: <201406031325.11589.marex@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Tuesday, June 03, 2014 at 03:59:49 AM, Simon Glass wrote: > Hi Marek, > > On 1 June 2014 11:33, Marek Vasut wrote: > > On Saturday, May 24, 2014 at 11:21:02 PM, Simon Glass wrote: > >> The root device should be probed just like any other device. The effect > >> of this is to mark the device as activated, so that it can be removed > >> (along with its children) if required. > >> > >> Signed-off-by: Simon Glass > >> --- > >> > >> drivers/core/root.c | 3 +++ > >> test/dm/core.c | 2 +- > >> 2 files changed, 4 insertions(+), 1 deletion(-) > >> > >> diff --git a/drivers/core/root.c b/drivers/core/root.c > >> index 4427b81..9fff164 100644 > >> --- a/drivers/core/root.c > >> +++ b/drivers/core/root.c > >> @@ -48,6 +48,9 @@ int dm_init(void) > >> > >> ret = device_bind_by_name(NULL, &root_info, &DM_ROOT()); > > > > Off-topic: This &DM_ROOT() above looks a little suspicious, don't you > > think? > > Yes. I wonder if it should not be written as a function? That'd be a good start. I cannot even find it's definition anywhere :-/ Best regards, Marek Vasut