From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [U-Boot, v5, 3/4] lib, fdt: move fdtdec_get_int() out of lib/fdtdec.c
Date: Thu, 5 Jun 2014 15:15:40 -0400 [thread overview]
Message-ID: <20140605191540.GA9129@bill-the-cat> (raw)
In-Reply-To: <1401269616-10303-4-git-send-email-hs@denx.de>
On Wed, May 28, 2014 at 11:33:35AM +0200, Heiko Schocher wrote:
> move fdtdec_get_int() out of lib/fdtdec.c into lib/fdtdec_common.c
> as this function is also used, if CONFIG_OF_CONTROL is not
> used. Poped up on the ids8313 board using signed FIT images,
> and activating CONFIG_SYS_GENERIC_BOARD. Without this patch
> it shows on boot:
>
> No valid FDT found - please append one to U-Boot binary, use u-boot-dtb.bin or define CONFIG_OF_EMBED. For sandbox, use -d <file.dtb>
>
> With this patch, it boots again with CONFIG_SYS_GENERIC_BOARD
> enabled.
>
> Signed-off-by: Heiko Schocher <hs@denx.de>
> Acked-by: Simon Glass <sjg@chromium.org>
> Cc: Tom Rini <trini@ti.com>
The problem is that on architectures with old compilers (sparc,
blackfin, nds32) this doesn't get discarded due to not being used but
instead causes link errors. Can you figure out which option
(CONFIG_FIT_SIGNATURE I suspect) drives this need and make sure we
include fdtdec_common.o then? Thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140605/b60befe2/attachment.pgp>
next prev parent reply other threads:[~2014-06-05 19:15 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-28 9:33 [U-Boot] [PATCH v5 0/4] mpc8313: ids8313 board updates Heiko Schocher
2014-05-28 9:33 ` [U-Boot] [PATCH v5 1/4] bootm: make use of legacy image format configurable Heiko Schocher
2014-05-30 22:44 ` Simon Glass
2014-06-05 22:47 ` [U-Boot] [U-Boot, v5, " Tom Rini
2014-05-28 9:33 ` [U-Boot] [PATCH v5 2/4] mpc8313, signed fit: enable legacy image format on ids8313 board Heiko Schocher
2014-05-30 22:45 ` Simon Glass
2014-05-30 22:46 ` Simon Glass
2014-06-05 22:47 ` [U-Boot] [U-Boot, v5, " Tom Rini
2014-05-28 9:33 ` [U-Boot] [PATCH v5 3/4] lib, fdt: move fdtdec_get_int() out of lib/fdtdec.c Heiko Schocher
2014-05-30 23:55 ` Simon Glass
2014-06-05 19:15 ` Tom Rini [this message]
2014-06-10 7:35 ` [U-Boot] [U-Boot, v5, " Heiko Schocher
2014-06-11 15:49 ` Tom Rini
2014-05-28 9:33 ` [U-Boot] [PATCH v5 4/4] mpc8313: add CONFIG_SYS_GENERIC_BOARD to ids8313 board Heiko Schocher
2014-05-30 22:45 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140605191540.GA9129@bill-the-cat \
--to=trini@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox