public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] U-boot hangs on imx6 pci driver
Date: Thu, 5 Jun 2014 19:53:28 +0200	[thread overview]
Message-ID: <201406051953.28676.marex@denx.de> (raw)
In-Reply-To: <CAOMZO5B2eTfHC2Rx7A3L5UhdmFV5r2jHpgLBwZpuxmGnEKd-zw@mail.gmail.com>

On Thursday, June 05, 2014 at 05:27:08 PM, Fabio Estevam wrote:
> Tim,
> 
> On Wed, Jun 4, 2014 at 9:16 PM, Tim Harvey <tharvey@gateworks.com> wrote:
> > work-around the problem on my end as well. Note that I do not see this
> > issue unless I'm using one of our boards with a PCIe switch and If I
> > disable PCI support in u-boot this does not occur. This feels like a
> 
> Does this help?
> 
>  drivers/pci/pcie_imx.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/pci/pcie_imx.c b/drivers/pci/pcie_imx.c
> index c48737e..190cdec 100644
> --- a/drivers/pci/pcie_imx.c
> +++ b/drivers/pci/pcie_imx.c
> @@ -435,8 +435,7 @@ static int imx6_pcie_init_phy(void)
>      clrbits_le32(&iomuxc_regs->gpr[12], IOMUXC_GPR12_APPS_LTSSM_ENABLE);
> 
>      clrsetbits_le32(&iomuxc_regs->gpr[12],
> -            IOMUXC_GPR12_DEVICE_TYPE_MASK,
> -            IOMUXC_GPR12_DEVICE_TYPE_RC);
> +            IOMUXC_GPR12_DEVICE_TYPE_MASK, 4 << 12);

Is this the setting of RC-mode in GPR12 ? That's wrong in the FSL datasheet, not 
in the code IIRC ;-)

Best regards,
Marek Vasut

  reply	other threads:[~2014-06-05 17:53 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-27 12:30 [U-Boot] U-boot hangs on imx6 pci driver Fabio Estevam
2014-05-27 13:25 ` Marek Vasut
2014-05-27 14:43   ` "David Müller (ELSOFT AG)"
2014-05-27 14:56     ` Marek Vasut
2014-05-28  7:40       ` "David Müller (ELSOFT AG)"
2014-05-28 16:43         ` Fabio Estevam
2014-05-30  7:04           ` "David Müller (ELSOFT AG)"
2014-06-05  0:16             ` Tim Harvey
2014-06-05  6:30               ` "David Müller (ELSOFT AG)"
2014-06-05 10:13                 ` Tim Harvey
2014-06-20  0:11                   ` Marek Vasut
2014-06-05 15:27               ` Fabio Estevam
2014-06-05 17:53                 ` Marek Vasut [this message]
2014-06-05 19:20                   ` Fabio Estevam
2014-06-05 22:04                     ` Marek Vasut
2014-06-05 22:14                       ` Fabio Estevam
2014-06-05 22:15                         ` Marek Vasut
2014-06-06  4:35                 ` Tim Harvey
2014-06-17 14:14                   ` Fabio Estevam
2014-06-20  0:22                     ` Marek Vasut
2014-05-28 16:42 ` Fabio Estevam
2014-05-28 18:31   ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201406051953.28676.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox